Virtualize the contexts and backends rather than templating#104
Draft
Matthew-Whitlock wants to merge 9 commits intomainfrom
Draft
Virtualize the contexts and backends rather than templating#104Matthew-Whitlock wants to merge 9 commits intomainfrom
Matthew-Whitlock wants to merge 9 commits intomainfrom
Conversation
Is this necessary? We should probably have a test case for this. Also back to using span() instead of size() for direct-serializing views, to account for possible padding.
Collaborator
Author
|
This has been broken up into multiple PRs, leaving here just to ensure all changes make it in eventually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions:
Should we allow making an UncoordinatedContext without passing an ID? It would default the ID to 0, and that would be fine as long as only 1 process is checkpointing or you have the checkpoint paths split up per process. It seems like a bit of a trap to allow? Maybe just detect conflicts and throw an exception?This doesn't seem all too importantI renamed the Impl::Registration namespace, because you otherwise can't use the Registration class name when inside the Impl namespace (e.g. inside AutomaticCheckpoint). I am open to being yelled at about unnecessary refactoring and overly broad changes, though.