Add status message when nvtx connectors are not built#280
Add status message when nvtx connectors are not built#280cwpearson wants to merge 2 commits intokokkos:developfrom
Conversation
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
|
#281 should fix the simple build failure. |
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
masterleinad
left a comment
There was a problem hiding this comment.
Would you mind adding similar messages for all the other tools?
I assume you mean for all the other third-party library connector tools in Kokkos Tools? It doesn't make sense for the in-house tools in Kokkos Tools, e.g., SpaceTimeStack, right? For this PR, maybe we do just VTune connector, roctx connector, and nvtx connector. I think handling a tool like the APEX Kokkos Tools connector may be slightly more complicated. I see that the roctx connector is handled now too in this PR. |
|
The ones I noticed missing are |
Got it, that makes sense then - and I think for this PR, it should just be ensured the CMake logic for each of the connectors consistent with each other, as @dalg24 commented. Thanks @cwpearson for looking at this! |
| add_subdirectory(profiling/nvtx-connector) | ||
| add_subdirectory(profiling/nvtx-focused-connector) | ||
| else() | ||
| message(STATUS "Skipping nvtx-connector: NVTX is not enabled (maybe Kokkos was not found, or not configured with the CUDA backend)") |
There was a problem hiding this comment.
I feel like that the message is potentially confusing, I would do just
| message(STATUS "Skipping nvtx-connector: NVTX is not enabled (maybe Kokkos was not found, or not configured with the CUDA backend)") | |
| message(STATUS "Skipping nvtx-connector (NVTX disabled)") |
We had a user who wasn't getting the nvtx connector built as expected. This may help clarify what's going on in the future.