Put LDMS Kokkos Tools connector (for perf. monitoring) in profiling directory#291
Open
vlkale wants to merge 10 commits intokokkos:developfrom
Open
Put LDMS Kokkos Tools connector (for perf. monitoring) in profiling directory#291vlkale wants to merge 10 commits intokokkos:developfrom
vlkale wants to merge 10 commits intokokkos:developfrom
Conversation
vlkale
changed the title
Contributor
Author
|
@nmm0 Can you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puts in the LDMS Kokkos Tools connector (for perf monitoring) and adds LDMS CMake and build system support for the LDMS connector.
Based on discussion today with @sswan, @jennfshr and @valleydlr, and brief update to @vsurjadidjaja, we are going with an integration within Kokkos Tools.
The integration within Kokkos Tools (as opposed to a github submodule) has been an option previously discussed with @vsurjadidjaja.
Note the Kokkos Tools LDMS connector has been primarily developed by @vsurjadidjaja, with some prior input from me. Both @vsurjadidjaja and @vlkale will review notes and feedback for this PR.
Important point for reviewers of this PR to check:
The Kokkos Tools sampler utility is intended to be fully decoupled from this connector. Note README currently states the sampler is an optional though recommended utility. Any such dependence, direct code and documentation for sampling from the Kokkos Tools side should not exist. If there are any other dependences of the Kokkos Tools sampler utility you find, please flag them.
I used help from Cursor AI for the FindLDMS.cmake. Note this provides a check for whether the OVIS-LDMS library exists.