fix(kernel-time): correct total/kernel time calculation in JSON output#326
Open
Benncs wants to merge 3 commits intokokkos:developfrom
Open
fix(kernel-time): correct total/kernel time calculation in JSON output#326Benncs wants to merge 3 commits intokokkos:developfrom
Benncs wants to merge 3 commits intokokkos:developfrom
Conversation
Contributor
|
Can you provide the output before and after this pull request? |
Author
|
With the develop branch on my program with the following environment variable Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
kp_kernel_timermiscalculated total time, kernel count, and total kernel time in JSON output. Problem was not present inkp_reader_json'and 'kp_readerimplementation.Fix
Reused
kp_reader_json's logic and unified code in kp_shared.Impact
kp_reader_jsontokp_shared