Open
Conversation
7ab57a8 to
a81bfe4
Compare
5d9589b to
1a6a8f7
Compare
dalg24
reviewed
Mar 13, 2026
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| kokkos-version-tag: [5.0.2, develop] |
Member
There was a problem hiding this comment.
I don't think we should test against develop in the CI but that belongs to nightlies or weeklies instead
Contributor
Author
There was a problem hiding this comment.
That's pre-existing at least.
Contributor
There was a problem hiding this comment.
I agree, I would take our latest 5 and latest 4 since we kind of promised long term support
vlkale
reviewed
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Do we also want to test for backward compatibility with earlier versions of Kokkos, say, Kokkos 4.5?
I agree at minimum a latest major release version of Kokkos (Kokkos 5.x right now) ought to be CI tested against Kokkos Tools weekly and even nightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting up for whatever range of versions we want to support in the end.