Open
Conversation
masterleinad
commented
Mar 20, 2026
| ) | ||
| if(HAVE_RESTRICT_WARNING) | ||
| target_compile_options(test_sampling_parfor PRIVATE "-Wno-restrict") | ||
| endif() |
Contributor
Author
There was a problem hiding this comment.
ndellingwood
approved these changes
Mar 23, 2026
Contributor
Contributor
|
I have no concerns that stick out. |
vlkale
approved these changes
Apr 1, 2026
Contributor
vlkale
left a comment
vlkale
left a comment
There was a problem hiding this comment.
Yes, adding -Wno-restrict to suppress this warning makes sense for the Kokkos Tools sampler utility tests and other tests we have for Kokkos Tools.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.