Conversation
|
Closes #67 |
|
@JBludau if you (or another maintainer) approve the workflows then I will be able to merge. |
|
I think we should also bump the minimum python version. Any suggestions? I think 3.10 would be a reasonable minimum. |
Supported python versions as per (https://devguide.python.org/versions/)[https://devguide.python.org/versions/]
Supported python versions as per (https://devguide.python.org/versions/)[https://devguide.python.org/versions/]
|
@JBludau I've updated the necessary workflows as per https://devguide.python.org/versions/, anything else I need to update? Also, I think the workflows need to be approved again. |
The versions are specified in multiple places, which should be unified. Also there is logic for python versions in pypy. I will take a look at the workflows later |
Remove formatting job for python 3.8
|
@JBludau Ok I updated Kokkos and also changed the python versions everywhere (I was being lazy before and missed some locations). Hopefully the tests pass now! |
JBludau
left a comment
There was a problem hiding this comment.
We can not just drop the formatting. Also there is multiple dead branches and ifs in the workflows now
Sorry about that. All the stale if branches are now gone and the formatting is back, let's hope everything works 🤞 |
JBludau
left a comment
There was a problem hiding this comment.
Kokkos now requires CMake>3.22
Co-authored-by: JBludau <104908666+JBludau@users.noreply.github.com>
Co-authored-by: JBludau <104908666+JBludau@users.noreply.github.com>
|
I guess CMake should be 3.31.6 |
|
@JBludau my thoughts handle the |
|
@JBludau is also looks like the |
|
No description provided.