Update reducer types allowed in parallel reduction.#221
Update reducer types allowed in parallel reduction.#221pkestene wants to merge 2 commits intokokkos:mainfrom
Conversation
NaderAlAwar
left a comment
There was a problem hiding this comment.
The changes look good. Would it be possible to add a test that confirms that this is working fine? I think you can extend this test
pykokkos/tests/test_parallelreduce.py
Line 79 in 01f920f
by simply parameterizing it on the other data types you added.
Sure, I'll update the test. But just to clarify beforehand: pykokkos/tests/test_parallelreduce.py Line 58 in 01f920f |
Looking at the generated C++, it seems that PyKokkos ignores the type supplied by the user and generates an |
Trying to fix #220