Interface: add support for mathematical special functions (real inputs only)#297
Open
kennykos wants to merge 4 commits intokokkos:mainfrom
Open
Interface: add support for mathematical special functions (real inputs only)#297kennykos wants to merge 4 commits intokokkos:mainfrom
kennykos wants to merge 4 commits intokokkos:mainfrom
Conversation
added 2 commits
December 18, 2024 11:27
Special functions defined in https://github.com/kokkos/kokkos/blob/9fa2a01747f0a30ca2723c8d7d0a22c95a05717a/core/src/Kokkos_MathematicalSpecialFunctions.hpp#L445 List of special functions: * expint1 * erfcx * cyl_bessel_j0 * cyl_bessel_y0 * cyl_bessel_i0 * cyl_bessel_k0 * cyl_bessel_j1 * cyl_bessel_y1 * cyl_bessel_i1 * cyl_bessel_k1 * cyl_bessel_h10 * cyl_bessel_h11 * cyl_bessel_h20 * cyl_bessel_h21
Collaborator
Author
|
This should close #296. |
gliga
reviewed
Dec 18, 2025
| @@ -1,6 +1,41 @@ | |||
| def expint1(input: float) -> float: | |||
Contributor
There was a problem hiding this comment.
providing some documentations for each of the functions would be helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for mathematical special functions defined in the header https://github.com/kokkos/kokkos/blob/9fa2a01747f0a30ca2723c8d7d0a22c95a05717a/core/src/Kokkos_MathematicalSpecialFunctions.hpp#L4.
The bessel functions pk.cyl_bessel_XX() are only supported for real data types as complex numbers are not yet supported in pykokkos.