Skip to content

ufunc removal#367

Open
nayyirahsan wants to merge 26 commits intokokkos:mainfrom
nayyirahsan:nayyirahsan/ufunc-removal
Open

ufunc removal#367
nayyirahsan wants to merge 26 commits intokokkos:mainfrom
nayyirahsan:nayyirahsan/ufunc-removal

Conversation

@nayyirahsan
Copy link
Copy Markdown
Contributor

Deleted ufunc implementations and tests. Replaced ufunc usage in examples with NumPy. Scalar math in kernels remains. Adjusted init.py and views.py accordingly. Array API CI workflow kept but precompile ufuncs test is commented out.

Addresses issue #361

@IvanGrigorik IvanGrigorik self-requested a review February 15, 2026 05:41
Comment thread examples/NaiveBayes/GaussianNB.py Outdated
@IvanGrigorik
Copy link
Copy Markdown
Collaborator

Overall LG
You also need to change some array api tests here
https://github.com/kokkos/pykokkos/pull/367/changes#diff-de4346c5bea6a8c4efd61f7378aac35876f468d8486137fa77b336175f429f8dR60

For example, remove the sqrt function (the function that was removed by this PR)

Comment thread pykokkos/lib/pk_array.py Outdated
Copy link
Copy Markdown
Collaborator

@IvanGrigorik IvanGrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok there are some serious problems that I missed on my first review.
If you have any access to Nvidia GPUs - please, try to test your changes on them using Cuda execution space (or run some existing examples/tests)

Unfortunately, we don't have any NVIDIA GitHub runners, and we can't verify the correctness of changes across different systems, so this burden lies on developers. :(

Comment thread pykokkos/interface/views.py Outdated
Comment thread pykokkos/interface/views.py Outdated
Comment thread pykokkos/interface/views.py Outdated
Comment thread pykokkos/interface/views.py Outdated
Comment thread pykokkos/__init__.py Outdated
Copy link
Copy Markdown
Collaborator

@IvanGrigorik IvanGrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything LG, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants