Conversation
…ples with NumPy. Scalar math in kernels remains. Adjusted __init__.py and views.py accordingly. Array API CI workflow kept but precompile ufuncs test is commented out. Addresses issue kokkos#361
|
Overall LG For example, remove the |
IvanGrigorik
left a comment
There was a problem hiding this comment.
Ok there are some serious problems that I missed on my first review.
If you have any access to Nvidia GPUs - please, try to test your changes on them using Cuda execution space (or run some existing examples/tests)
Unfortunately, we don't have any NVIDIA GitHub runners, and we can't verify the correctness of changes across different systems, so this burden lies on developers. :(
IvanGrigorik
left a comment
There was a problem hiding this comment.
Now everything LG, thanks
Deleted ufunc implementations and tests. Replaced ufunc usage in examples with NumPy. Scalar math in kernels remains. Adjusted init.py and views.py accordingly. Array API CI workflow kept but precompile ufuncs test is commented out.
Addresses issue #361