core: update to kokkos 5.0.02 update - #377
Conversation
bb5b3fb to
5e9fe94
Compare
5e9fe94 to
66aad01
Compare
|
There is some problem with CI itself |
| IF(Kokkos_ENABLE_CUDA_UVM) | ||
| SET(Kokkos_ENABLE_DEPRECATED_CODE_4 ON CACHE BOOL "Required for Kokkos_ENABLE_CUDA_UVM in Kokkos 5+" FORCE) | ||
| ENDIF() |
There was a problem hiding this comment.
hmm do we know why we require this? because this will go away eventually
There was a problem hiding this comment.
Without that, we will run into an issue during the PyKokkos compilation process:
CMake Error at _skbuild/linux-x86_64-3.13/cmake-build/_deps/kokkos-src/cmake/kokkos_arch.cmake:1422 (message):
Kokkos_ENABLE_DEPRECATED_CODE_4 must be set to use Kokkos_ENABLE_CUDA_UVM
Call Stack (most recent call first):
_skbuild/linux-x86_64-3.13/cmake-build/_deps/kokkos-src/cmake/kokkos_tribits.cmake:161 (include)
_skbuild/linux-x86_64-3.13/cmake-build/_deps/kokkos-src/CMakeLists.txt:212 (kokkos_setup_build_environment)
If we want to remove unified memory support, we should remove this option altogether, but that definitely should be a different PR, since there are multiple dependencies in the core
|
There are some deprecations in Kokkos 5 that we hit in the CI. I have a local version that fixes these. Is it fine if I push to your branch? |
Sure. Thanks! |
|
@IvanGrigorik can you resolve the merge conflicts so we can get back to work on this? |
|
This in on me...I will try to brush up on the branch that I have locally and push. |
3 participants
This PR updates the Kokkos version from 4.7.01 to 5.0.02