Fix atomic fetch op pattern matching in workunit visitor#405
Merged
IvanGrigorik merged 1 commit intokokkos:mainfrom Mar 31, 2026
Merged
Fix atomic fetch op pattern matching in workunit visitor#405IvanGrigorik merged 1 commit intokokkos:mainfrom
IvanGrigorik merged 1 commit intokokkos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the regex shall be atomic_fetch_* rather than atomic_*,
otherwise, the logic will make atomic_fetch_op to be true when using atomic_compare_exchange, then the if statement : "if not is_atomic_increment and is_atomic_fetch_op and len(args) != 3:" will evaluated to true, which causes the problem