set UVM off by default if CUDA is enabled (deprecated by Kokkos)#418
Open
IvanGrigorik wants to merge 1 commit intomainfrom
Open
set UVM off by default if CUDA is enabled (deprecated by Kokkos)#418IvanGrigorik wants to merge 1 commit intomainfrom
IvanGrigorik wants to merge 1 commit intomainfrom
Conversation
JBludau
reviewed
May 6, 2026
Contributor
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
Since the option will be removed at some point, why not just delete it completely? The default for that option is OFF anyways
Collaborator
|
Also, this change should be reflected in the CMake flags section of the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated CUDA
UVMmemory space option, which causes slowdowns due to page-fetch faults during kernel execution.