Test fmin and fmax functions - #419
Open
kennykos wants to merge 1 commit into
Open
Conversation
JBludau
reviewed
May 15, 2026
|
|
||
| @pk.workunit | ||
| def fmin_workunit(tid: int, view: pk.View1D[pk.double]) -> None: | ||
| nan: pk.double = 1 / 0 - 1 / 0 |
Contributor
There was a problem hiding this comment.
hmm ... maybe testing against nan is not the best idea since it compares not equal to itself.
How about using the max/min val for double?
IvanGrigorik
requested changes
May 25, 2026
IvanGrigorik
left a comment
IvanGrigorik
left a comment
Collaborator
There was a problem hiding this comment.
Please use FMAX / FMIN to test it
Collaborator
Author
what do you mean by this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.