layout_blas_general does not have an _extents member#305
Merged
mhoemmen merged 2 commits intokokkos:mainfrom May 21, 2025
Merged
layout_blas_general does not have an _extents member#305mhoemmen merged 2 commits intokokkos:mainfrom
mhoemmen merged 2 commits intokokkos:mainfrom
Conversation
Fix for issue kokkos#299 where we try to assign to _extents instead of assigning to _base_layout.extents Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Contributor
|
Btw, we replaced |
Contributor
Author
|
Ah that's good to know, this bug was preventing me from compiling the code so figured I would send a fix but I can modify my PR to just remove |
Contributor
|
@lucbv wrote:
That would be delightful of you -- thank you! : - ) |
This removes the definition and use of the deprecated layout_blas_general which was replace with layout_left_padded and layout_right_padded in P2642 Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Contributor
|
@youyu3 FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #299 where we try to assign to _extents instead of assigning to _base_layout.extents