Default unknown free_busy values to busy - #6
Open
mmonterroca wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default missing or unknown
free_busyvalues tobusywhen saving events through the database driver.This prevents iTIP imports/updates from failing when an incoming ICS does not provide a recognized free/busy value.
Observed error
In production, an iTIP update from a Microsoft Teams / Outlook invitation failed with:
The failing SQL attempted to update an existing event with:
The MySQL schema defines the column as:
Cause
_save_preprocess()maps missing or unrecognizedfree_busyvalues tonull:That conflicts with the database schema during updates.
Fix
Use
busyas the default fallback:For meeting invitations, defaulting to busy is safer than failing the import/update and matches normal calendar behavior when no transparency value is present.
Testing
php -l drivers/database/database_driver.php.Note: I could not open a separate issue because issues are disabled on this repository.