Skip to content

Add benchmark tests for Windows tables #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Add benchmark tests for Windows tables #2182

wants to merge 35 commits into from

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Mar 26, 2025 •
edited
Loading 

go test -bench=. -benchmem -cpuprofile=cpu-all.out -memprofile=mem-all.out

@RebeccaMahany
Basic benchmark for ProgramIcons
1c8c5da
@RebeccaMahany
Benchmark for kolide_dsim_default_associations
abc811e
@RebeccaMahany
Add benchmark for Windows update tables
7b80e2d
@RebeccaMahany
B.Loop()
68766bd
@RebeccaMahany
b.N actually
3ebe518
@RebeccaMahany
Consolidate into one test file
9dcc340
@RebeccaMahany
Add constraints for wmi test
b2ad650
@RebeccaMahany
Fix
afa0d7d
@RebeccaMahany
Fix again
7a67cec
@RebeccaMahany
Capture memstats before and after calling each table
0935a2a
@RebeccaMahany
Better stats reporting
9795b70
@RebeccaMahany
The rest of the tables
c0f5488
@RebeccaMahany
More stats more improvements
b055249
@RebeccaMahany
More stats more improvements 2
fdc1b99
@RebeccaMahany
More stats more improvements 3
09291bc
@RebeccaMahany
More stats more improvements 4
59f7ddf
@RebeccaMahany
Timeout should be 4min for accuracy
897306b
@RebeccaMahany
memprofile for diff
c5be5b3
@RebeccaMahany
Try estimating go/non-go memory usage
d34a36e
@RebeccaMahany
More table calls
df19db2
@RebeccaMahany
Wrong spot for t.Parallel
3e7fa84
@RebeccaMahany
Immediately changed my mind about t.Parallel
e7e427c
@RebeccaMahany
More platform tables plus collect stats after each table
6fdcaf5
@RebeccaMahany
Test just for the windows updates table
4534fe7
@RebeccaMahany
Try history table
4f98df4
@RebeccaMahany
Smaller batches, more data
f67ea90
@RebeccaMahany
rm unused test
f609a06
@RebeccaMahany
New test for windowsupdate
94da719
@RebeccaMahany
More granular
17d7c5b
@RebeccaMahany
again
42ff567
@RebeccaMahany RebeccaMahany force-pushed the becca/benchmark-generate branch from dad1b3d to 47f4884 Compare March 28, 2025 14:27
@RebeccaMahany RebeccaMahany mentioned this pull request Apr 3, 2025
Draft
@directionless
Copy link
Contributor

I wonder if there's a way to make this part of CI.

@RebeccaMahany
Copy link
Contributor Author

@directionless I'm pulling in some of this work into #2191 -- still a draft PR, but there are tests there as a tentative way to confirm memory usage in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @directionless