-
Notifications
You must be signed in to change notification settings - Fork 361
Issue #258: fix link button #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 22.10% 22.10%
=======================================
Files 7 7
Lines 484 484
Branches 102 102
=======================================
Hits 107 107
- Misses 365 367 +2
+ Partials 12 10 -2 ☔ View full report in Codecov by Sentry. |
Bump on this fix |
Thanks! I will try to check this soon as possible. |
|
Thanks. I implemented provide one service instance per one editor component. Is it correct for your opinion? |
@kolkov The latest |
Link button problem arises from commit afe8176. Couldn't figure out what it does, but service is already provided in root and with this commit is injected separately in each component, so they don't share selected text anymore