Skip to content

Issue #258: fix link button #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #258: fix link button #262

wants to merge 1 commit into from

Conversation

NikKropin
Copy link

Link button problem arises from commit afe8176. Couldn't figure out what it does, but service is already provided in root and with this commit is injected separately in each component, so they don't share selected text anymore

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.10%. Comparing base (d1f94a6) to head (3a30569).
Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   22.10%   22.10%           
=======================================
  Files           7        7           
  Lines         484      484           
  Branches      102      102           
=======================================
  Hits          107      107           
- Misses        365      367    +2     
+ Partials       12       10    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachonk
Copy link

bachonk commented Aug 19, 2020

Bump on this fix

@kolkov
Copy link
Owner

kolkov commented Aug 19, 2020

Thanks! I will try to check this soon as possible.

@kolkov
Copy link
Owner

kolkov commented Aug 19, 2020

Link button problem arises from commit afe8176. Couldn't figure out what it does, but service is already provided in root and with this commit is injected separately in each component, so they don't share selected text anymore
Thanks! But the main problem is for multiple editors on the same page. We need to discover solution with this functionality. @NikKropin

@alexgurrola
Copy link

@kolkov I compiled this fix locally and tested it. It works in Angular 10 and fixes the issues with the Link and Custom Classes button.

Fixes: #278

anthonygrado added a commit to anthonygrado/angular-editor that referenced this pull request Oct 7, 2020
@kolkov
Copy link
Owner

kolkov commented Oct 24, 2020

Thanks. I implemented provide one service instance per one editor component. Is it correct for your opinion?

@alexgurrola
Copy link

alexgurrola commented Oct 27, 2020

@kolkov The latest 1.1.5 release fixes all of my outstanding issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants