Skip to content

Conversation

@kolosovpetro
Copy link
Owner

@kolosovpetro kolosovpetro commented Feb 7, 2025

v1.1.0 - In Progress

Changed

  • Windows 2022 base image for windows-server2022-v4.pkr.hcl
  • Windows 2019 base image for windows-server2019-v4.pkr.hcl
  • Verifies image Windows Server images integrity using scf scan and DISM
  • Configures WinRM for Ansible as part of images
  • Images are tested using Terraform
  • Add encoding fix PowerShell script (removes BOM and fixes EOL)
  • Arrange images folder structure for better code maintainability
  • Each image contains README file with complete guide how to build it
  • Add PowerShell script for Packer init and validate images

Installed software v4

  • azure-cli
  • microsoft-edge
  • git
  • netfx-4.8-devpack
  • dotnet-6.0-sdk
  • powershell-core
  • winrar
  • notepadplusplus
  • sql-server-management-studio
  • azcopy10

@kolosovpetro kolosovpetro self-assigned this Feb 7, 2025
@gitguardian
Copy link

gitguardian bot commented Feb 7, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15519839 Triggered Generic Terraform Variable Secret b170c2a packer-images/windows-2019/variables.tf View secret
15519840 Triggered Generic Terraform Variable Secret b84a382 packer-images/windows-2022/variables.tf View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@kolosovpetro kolosovpetro merged commit 5409e63 into master Feb 7, 2025
2 checks passed
@kolosovpetro kolosovpetro deleted the AZ400-222 branch February 7, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants