feat(RELEASE-1725): auto generate README.md files for tasks/pipelines#22
Conversation
|
Changed PR and commit title because of new ticket |
johnbieren
left a comment
There was a problem hiding this comment.
Are the two bash scripts exactly the same as the ones in release-service-catalog (to save review time)? Can you update the contributing doc?
|
Yeah, I'm waiting for the scripts to be approved in release-service-catalog (konflux-ci/release-service-catalog#1157) - I will copy them over once they are merged, these scripts are outdated. I marked it as work-in-progress to stop people from reviewing the same script twice. I was also planning to add the contributing doc in the PR for https://issues.redhat.com/browse/RELEASE-1493 and include the automatic README in that. |
4ba7d3c to
635d6cf
Compare
Are they the same now? |
7ecde38 to
418b727
Compare
|
They should be the same now, except for |
ed8ddbb to
959f391
Compare
aka not the same 😅 |
|
yeah 😅 |
fc72027 to
2bdd937
Compare
d61ce5d to
e4f08c0
Compare
|
/lgtm Just testing to make adding LGTM to my own PR isn't possible |
|
@Paul123111: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Also, is this PR ready to be merged or does it need some more changes? There aren't any unresolved conversations |
I don't have any more changes to ask for but others should review it too |
c9982ec to
9c1d28a
Compare
Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh. Also updated all README.md files using this script. Signed-off-by: Paul Fitzgerald <pafitzge@redhat.com>
|
This lgtm, apart from the unresolved comments from @theflockers. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Paul123111, theflockers The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
477b193
into
konflux-ci:development
Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh.
Also updated all README.md files using this script.