Skip to content

feat(RELEASE-1725): auto generate README.md files for tasks/pipelines#22

Merged
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:developmentfrom
Paul123111:development
Jul 21, 2025
Merged

feat(RELEASE-1725): auto generate README.md files for tasks/pipelines#22
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:developmentfrom
Paul123111:development

Conversation

@Paul123111

@Paul123111 Paul123111 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh.

Also updated all README.md files using this script.

@openshift-ci openshift-ci Bot requested review from happybhati and johnbieren June 30, 2025 15:56
@Paul123111 Paul123111 changed the title feat(RELEASE-1675): auto generate README.md files for tasks/pipelines feat(RELEASE-1725): auto generate README.md files for tasks/pipelines Jul 2, 2025
@Paul123111

Copy link
Copy Markdown
Contributor Author

Changed PR and commit title because of new ticket

@johnbieren johnbieren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two bash scripts exactly the same as the ones in release-service-catalog (to save review time)? Can you update the contributing doc?

@Paul123111

Paul123111 commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, I'm waiting for the scripts to be approved in release-service-catalog (konflux-ci/release-service-catalog#1157) - I will copy them over once they are merged, these scripts are outdated. I marked it as work-in-progress to stop people from reviewing the same script twice.

I was also planning to add the contributing doc in the PR for https://issues.redhat.com/browse/RELEASE-1493 and include the automatic README in that.

@johnbieren

Copy link
Copy Markdown
Contributor

Yeah, I'm waiting for the scripts to be approved in release-service-catalog (konflux-ci/release-service-catalog#1157) - I will copy them over once they are merged, these scripts are outdated. I marked it as work-in-progress to stop people from reviewing the same script twice.

I was also planning to add the contributing doc in the PR for https://issues.redhat.com/browse/RELEASE-1493 and include the automatic README in that.

Are they the same now?

@Paul123111 Paul123111 force-pushed the development branch 2 times, most recently from 7ecde38 to 418b727 Compare July 11, 2025 11:19
@Paul123111

Paul123111 commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

They should be the same now, except for a failsafe to skip test directories in check_readme.sh, and changing the scripts and workflow to account for how tasks/pipelines are kept as tasks/task-name instead of tasks/managed/task-name.

@Paul123111 Paul123111 force-pushed the development branch 2 times, most recently from ed8ddbb to 959f391 Compare July 11, 2025 11:38
@johnbieren

Copy link
Copy Markdown
Contributor

They should be the same now, except for a failsafe to skip test directories in check_readme.sh, and changing the scripts and workflow to account for how tasks/pipelines are kept as tasks/task-name instead of tasks/managed/task-name.

aka not the same 😅

@Paul123111

Copy link
Copy Markdown
Contributor Author

yeah 😅

Comment thread .github/workflows/lint.yaml Outdated
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/scripts/readme_generator.sh Outdated
Comment thread .github/scripts/readme_generator.sh Outdated
Comment thread .github/scripts/readme_generator.sh Outdated
@Paul123111 Paul123111 force-pushed the development branch 3 times, most recently from d61ce5d to e4f08c0 Compare July 15, 2025 15:20
@Paul123111

Paul123111 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

/lgtm

Just testing to make adding LGTM to my own PR isn't possible

@openshift-ci

openshift-ci Bot commented Jul 15, 2025

Copy link
Copy Markdown

@Paul123111: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Paul123111

Paul123111 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Also, is this PR ready to be merged or does it need some more changes? There aren't any unresolved conversations

@johnbieren

Copy link
Copy Markdown
Contributor

Also, is this PR ready to be merged or does it need some more changes? There aren't any unresolved conversations

I don't have any more changes to ask for but others should review it too

Comment thread .github/scripts/readme_generator.sh Outdated
@Paul123111 Paul123111 force-pushed the development branch 3 times, most recently from c9982ec to 9c1d28a Compare July 16, 2025 15:55
Add readme_generator.sh, which generates README.md files
for tasks and pipelines, as well as a check_readme.sh script and
workflow to check that the README.md files in each task and pipeline
match the output of readme-generator.sh.

Also updated all README.md files using this script.

Signed-off-by: Paul Fitzgerald <pafitzge@redhat.com>
@FilipNikolovski

Copy link
Copy Markdown

This lgtm, apart from the unresolved comments from @theflockers.

@openshift-ci

openshift-ci Bot commented Jul 21, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Paul123111, theflockers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Paul123111,theflockers]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 477b193 into konflux-ci:development Jul 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants