Use normalized platform spec for built-in ARGs#14
Merged
chmeliik merged 2 commits intokonflux-ci:devfrom Feb 23, 2026
Merged
Conversation
The ioutil package has been deprecated since Go 1.16. This change replaces the deprecated ioutil.Discard with the recommended io.Discard to ensure compatibility with future Go versions and follow best practices. -- https://github.com/golang/go/blob/master/src/io/ioutil/ioutil.go#L105 Signed-off-by: Michal Šoltis <msoltis@redhat.com>
The default platform spec may not be normalized, which can cause inconsistencies when used for built-in Docker ARG variables. By normalizing the platform spec, we ensure consistent formatting across different environments. -- https://github.com/containerd/platforms/blob/2e51fd9435bd985e1753954b24f4b0453f4e4767/platforms.go#L336 Signed-off-by: Michal Šoltis <msoltis@redhat.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
chmeliik
approved these changes
Feb 23, 2026
|
Thanks for the fix and for fixing the deprecation warning 🌮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context here: konflux-ci/konflux-build-cli#66