fix: scope e2e image update sed to avoid corrupting digests - #1886
fix: scope e2e image update sed to avoid corrupting digests#1886bacciotti wants to merge 1 commit into
Conversation
Scope the SHA replacement to konflux-e2e-tests image tags only so unrelated @sha256 digests in the same file are left intact. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi @bacciotti. Thanks for your PR. I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR Summary by QodoScope e2e image tag rewrite to avoid corrupting unrelated SHA256 digests
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
bacciotti
changed the title
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tisutisu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scenario: konflux-e2e
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-7r8sjTest results analysis🚨 No JUnit file found, see the log from running tests: Click to view logs./mage -v ci:teste2e Running target: CI:TestE2E I0728 07:29:38.077042 11546 magefile.go:525] setting up new custom bundle for testing... I0728 07:29:38.539284 11546 util.go:512] found credentials for image ref quay.io/redhat-appstudio-qe/test-images:pipeline-bundle-1785223778-ssob -> user: redhat-appstudio-qe+redhat_appstudio_quality Creating Tekton Bundle: - Added Pipeline: docker-build to image I0728 07:29:40.185675 11546 bundle.go:57] image digest for a new tekton bundle quay.io/redhat-appstudio-qe/test-images:pipeline-bundle-1785223778-ssob: quay.io/redhat-appstudio-qe/test-images@sha256:8cb636c90a89dd0fa53966ece00f5136298fcf538bc0d4a98534a1274be1fd3b I0728 07:29:40.185694 11546 magefile.go:531] To use the custom docker bundle locally, run below cmd:
=============================================================================
|
|
/retest |
|
we are configuring renovate to update the image now, we may remove updating reference from this pipeline now. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Summary
.tekton/konflux-e2e-tests-push.yamlso it only rewriteskonflux-e2e-tests:<40-hex>tags.s/[0-9a-f]{40}/…/galso matched the first 40 hex chars of unrelated@sha256:digests in the same YAML (e.g.task-runner), corrupting downstream update PRs.Fixes the root cause of konflux-ci/build-definitions#3669 (seen in build-definitions PRs #3601 and #3668).
Test plan
sedupdates only the e2e image line.mainthat runsupdate-build-definitions-reposhould open an “e2e-tests update” PR that changes only thekonflux-e2e-tests:tag (digest oftask-runnerunchanged).build-tasks-dockerfilesupdate PR (integration-tests/tasks/e2e-test.yaml).Made with Cursor