feat(KFLUXUI-883): change the default image repo visibility from publ… #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
/retest |
testcara
force-pushed
the
image-visibility
branch
from
9dce847 to
42cefe0
Compare
mmorhun
reviewed
Dec 19, 2025
|
|
||
| if imageRepository.Spec.Image.Visibility == "" { | ||
| imageRepository.Spec.Image.Visibility = imagerepositoryv1alpha1.ImageVisibilityPublic | ||
| imageRepository.Spec.Image.Visibility = imagerepositoryv1alpha1.ImageVisibilityPrivate |
Member
There was a problem hiding this comment.
I'm not sure about the change.
Having all images private by default requires a paid plan on quay, which makes defaults not usable in upstream Konflux. So admins would have to pay for a quay plan or specify public visibility for every image, which is not a user friendly approach.
I suggest to have it configurable via an env var. If the env var is not set, it means public (to not to break current behavior).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by the feature User access to artifacts built by Konflux, the UI now changes the default image repository visibility from public to private.
We need to update the visibility settings here accordingly.