Skip to content

fix: add more memory to snapshot garbage collector#1395

Merged
dirgim merged 1 commit into
konflux-ci:mainfrom
dirgim:add-snapshotgc-memory
Jan 14, 2026
Merged

fix: add more memory to snapshot garbage collector#1395
dirgim merged 1 commit into
konflux-ci:mainfrom
dirgim:add-snapshotgc-memory

Conversation

@dirgim

@dirgim dirgim commented Dec 17, 2025

Copy link
Copy Markdown
Member
  • The gc is running into OOM errors on very busy clusters

Signed-off-by: dirgim kpavic@redhat.com

Maintainers will complete the following section

@snyk-io

snyk-io Bot commented Dec 17, 2025

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov-commenter

codecov-commenter commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.50%. Comparing base (a833e2e) to head (23a801b).
⚠️ Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   65.89%   74.50%   +8.61%     
==========================================
  Files          51       51              
  Lines        6456     6456              
==========================================
+ Hits         4254     4810     +556     
+ Misses       1711     1178     -533     
+ Partials      491      468      -23     
Flag Coverage Δ
e2e-tests 56.22% <ø> (?)
unit-tests 65.78% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonam1412

Copy link
Copy Markdown
Collaborator

/retest

@Josh-Everett

Copy link
Copy Markdown
Contributor

/retest

@dirgim dirgim force-pushed the add-snapshotgc-memory branch from b2981a1 to 2cc34f4 Compare January 2, 2026 14:29
@dirgim

dirgim commented Jan 2, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@kasemAlem

Copy link
Copy Markdown
Contributor

/retest

@dirgim dirgim force-pushed the add-snapshotgc-memory branch from 2cc34f4 to 495b706 Compare January 6, 2026 16:24
@dirgim

dirgim commented Jan 6, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@kasemAlem

Copy link
Copy Markdown
Contributor

/retest

@dirgim

dirgim commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@dirgim

dirgim commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

/retest

@hongweiliu17

Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@dirgim

dirgim commented Jan 8, 2026

Copy link
Copy Markdown
Member Author

/retest

@NigelByrne1 NigelByrne1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirgim

dirgim commented Jan 8, 2026

Copy link
Copy Markdown
Member Author

/retest

@Josh-Everett

Copy link
Copy Markdown
Contributor

/retest

5 similar comments
@dirgim

dirgim commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

/retest

@Josh-Everett

Copy link
Copy Markdown
Contributor

/retest

@kasemAlem

Copy link
Copy Markdown
Contributor

/retest

@Josh-Everett

Copy link
Copy Markdown
Contributor

/retest

@hongweiliu17

Copy link
Copy Markdown
Contributor

/retest

@kasemAlem

Copy link
Copy Markdown
Contributor

@dirgim , seem like this one need a rebase, isn't ?

* The gc is running into OOM errors on
  very busy clusters

Signed-off-by: dirgim <kpavic@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@dirgim dirgim force-pushed the add-snapshotgc-memory branch from 495b706 to 23a801b Compare January 13, 2026 10:39
@kasemAlem

Copy link
Copy Markdown
Contributor

/retest

2 similar comments
@kasemAlem

Copy link
Copy Markdown
Contributor

/retest

@dirgim

dirgim commented Jan 13, 2026

Copy link
Copy Markdown
Member Author

/retest

@dirgim dirgim merged commit 85cbba7 into konflux-ci:main Jan 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants