Skip to content

feat: Add ComponentGroup CRD (STONEINTG-1348)#1396

Merged
kasemAlem merged 1 commit into
konflux-ci:mainfrom
kasemAlem:STONEINTG-1348
Jan 14, 2026
Merged

feat: Add ComponentGroup CRD (STONEINTG-1348)#1396
kasemAlem merged 1 commit into
konflux-ci:mainfrom
kasemAlem:STONEINTG-1348

Conversation

@kasemAlem

Copy link
Copy Markdown
Contributor

Implements ComponentGroup CRD per STONEINTG-1302 design doc.

  • Add ComponentGroup types with Components, Dependents, TestGraph fields
  • Add GCL tracking (lastPromotedImage, lastPromotedCommit, lastBuildTime)
  • Add 8 unit tests (all passing)
  • Generate CRD manifest and DeepCopy methods
  • Add RBAC roles (admin, editor, viewer)
  • Update kustomization files

Maintainers will complete the following section

@snyk-io

snyk-io Bot commented Dec 17, 2025

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov-commenter

codecov-commenter commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (a833e2e) to head (92a0fc4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   65.89%   74.26%   +8.37%     
==========================================
  Files          51       52       +1     
  Lines        6456     6458       +2     
==========================================
+ Hits         4254     4796     +542     
+ Misses       1711     1192     -519     
+ Partials      491      470      -21     
Flag Coverage Δ
e2e-tests 55.53% <100.00%> (?)
unit-tests 66.05% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kasemAlem kasemAlem force-pushed the STONEINTG-1348 branch 7 times, most recently from 899f01f to 2bbf57f Compare December 18, 2025 13:54
@jsztuka

jsztuka commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

/retest

@kasemAlem kasemAlem force-pushed the STONEINTG-1348 branch 3 times, most recently from 6d25417 to 06bdd44 Compare December 22, 2025 18:36
@jencull

jencull commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

/retest

@jsztuka

jsztuka commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

/retest

@dirgim dirgim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, will defer to @14rcole for the final say on how the CRD conforms to STONEINTG-1302.

Implements ComponentGroup CRD per STONEINTG-1302 design doc.

- Add ComponentGroup types with Components, Dependents, TestGraph fields
- Add GCL tracking(lastPromotedImage,lastPromotedCommit,lastBuildTime)
- Add 8 unit tests (all passing)
- Generate CRD manifest and DeepCopy methods
- Add RBAC roles (admin, editor, viewer)
- Update kustomization files

Signed-off-by: Kasem Alem <kalem@redhat.com>

@14rcole 14rcole left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the hard work

@kasemAlem kasemAlem merged commit 8e8e1e4 into konflux-ci:main Jan 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants