fix(deps): update module github.com/santhosh-tekuri/jsonschema/v5 to v6#1481
Conversation
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dbe315d to
fb0c9a9
Compare
fb0c9a9 to
b0b9234
Compare
7bb9607 to
e1256a5
Compare
ReviewFindingsCritical
Previous runReviewFindingsCritical
Previous run (2)ReviewFindingsCritical
Medium
Low
Labels: Go dependency update PR that modifies go.mod. Previous run (3)ReviewFindingsCritical
Labels: Renovate bot dependency version bump PR. Previous run (4)ReviewFindingsCritical
Previous run (5)ReviewFindingsCritical
Medium
Info
Previous run (6)ReviewFindingsCritical
|
|
🤖 Finished Retro · ✅ Success · Started 2:46 PM UTC · Completed 2:50 PM UTC |
Retro: PR #1481 (autoclosed Renovate dependency bump)Timeline: Renovate bot created this PR on 2026-02-26 to bump Review quality: Good. The review bot accurately identified that three source files still imported Wasted work identified:
No new proposals. All identified improvements are already tracked by existing open issues in fullsend-ai/fullsend. |
|
🤖 Finished Review · ✅ Success · Started 6:44 PM UTC · Completed 6:50 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 10:49 PM UTC · Completed 10:53 PM UTC |
|
This is the second retro run on PR #1481, an autoclosed Renovate bot PR that bumped A previous retro (run Existing issues already cover every identified waste pattern:
This retro run is itself an instance of the problem described in #2401 and #2461 — wasted compute on a PR that has already been retro'd and has no new information. |
|
🤖 Finished Review · ✅ Success · Started 5:44 AM UTC · Completed 5:51 AM UTC |
|
🤖 Finished Review · ✅ Success · Started 10:33 PM UTC · Completed 10:42 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 1:55 AM UTC · Completed 2:01 AM UTC |
Retro: PR #1481 — jsonschema v5→v6 bot dependency bump (autoclosed)This is the third retro on this PR. The previous two retros (runs 27907808818 and 27989217810) already identified all waste patterns and linked them to existing open issues. No new proposals are warranted. What happened
Total wasted compute: 4 redundant review runs + 3 retro runs on a bot PR that was broken from day one and never going to be fixed. Why no new proposalsEvery improvement opportunity identified here is already tracked by open issues in
The review agent's detection quality was excellent — it correctly identified the critical compilation issue on every run. The problem is purely at the dispatch layer: guards to prevent running agents on closed, bot-authored, or already-reviewed PRs have not yet been implemented despite being well-documented. |
|
🤖 Finished Review · ✅ Success · Started 6:29 AM UTC · Completed 6:38 AM UTC |
|
🤖 Review · ❌ Terminated · Started 3:05 PM UTC · Ended 3:16 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 7:05 PM UTC · Completed 7:11 PM UTC |
Retro: PR #1481 — Renovate major version bump (jsonschema v5→v6)Timeline: Renovate bot created this 1-line Review quality: The review agent correctly identified the critical compilation-breaking issue on every run — good detection, but massive redundancy. Key waste: ~6x review cost and ~3x retro cost for zero incremental value after the first review. All known improvement vectors are already tracked upstream:
One gap remains: no existing issue proposes a time-based mechanism to detect and auto-close bot PRs that have been open with consistently failing CI and no human engagement for an extended period. Issue #1980 covers review-time closure but not periodic detection of stale broken bot PRs. Proposals filed
|
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
🤖 Finished Review · ✅ Success · Started 1:34 AM UTC · Completed 1:39 AM UTC |
| github.com/google/go-github/v45 v45.2.0 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 | ||
| github.com/santhosh-tekuri/jsonschema/v6 v6.0.2 |
There was a problem hiding this comment.
[critical] api-contract
The PR changes go.mod from jsonschema/v5 to jsonschema/v6, but this is the only file changed. Three source files (helpers/integration.go:35, gitops/snapshot.go:38, pkg/integrationteststatus/integration_test_status.go:27) still import v5. The go.sum file contains only v5 entries, and vendor/modules.txt also references v5. Since Go treats major versions as distinct module paths, go.mod will declare a dependency (v6) that no code imports, while the actually-imported v5 path is no longer declared. The build will fail. Additionally, v5-to-v6 is a breaking API change requiring call-site updates beyond just import path changes.
Suggested fix: Update all three source files to import github.com/santhosh-tekuri/jsonschema/v6, update API call sites to match v6 signatures (consult the v6 migration guide), run go mod tidy to regenerate go.sum, and re-vendor dependencies. Alternatively, if the API migration is not yet ready, close this Renovate PR and pin the dependency to v5.
This PR contains the following updates:
v5.3.1→v6.0.2Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
santhosh-tekuri/jsonschema (github.com/santhosh-tekuri/jsonschema/v5)
v6.0.2Compare Source
v6.0.1Compare Source
Bug Fixes:
check https://redirect.github.com/santhosh-tekuri/jsonschema/discussions/172 to see notes for migrating from v5 to v6
v6.0.0Compare Source
Improvements
$vocabularysupportsermverformatValidationErrorjv--insecureand--cacertflag--quietflagcheck https://redirect.github.com/santhosh-tekuri/jsonschema/discussions/172 to see notes for migrating from v5 to v6
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.