fix: register spec.application index for ReleasePlan in snapshot controller#1555
Closed
ci-operator wants to merge 1 commit into
Closed
fix: register spec.application index for ReleasePlan in snapshot controller#1555ci-operator wants to merge 1 commit into
ci-operator wants to merge 1 commit into
Conversation
ci-operator
requested review from
14rcole,
Josh-Everett,
NigelByrne1,
dirgim,
jencull,
jsztuka,
kasemAlem and
sonam1412
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a cache setup for the legacy application model in the snapshot controller. The reviewer suggests also including the IntegrationTestScenario cache for the old application model to ensure full compatibility for legacy tenants and consistency with other controllers.
ci-operator
force-pushed
the
fix-releaseplan-application-index
branch
from
6b6a212 to
fd47d05
Compare
…roller ec4a274 (konflux-ci#1409) split SetupReleasePlanCache into a componentGroup-indexed default and a *Application variant for the legacy path. The integrationpipeline controller's setupCache calls both; the snapshot controller's calls only the new one, so reconciles on Application-model tenants fail with: Index with name field:spec.application does not exist Add the missing call. (IntegrationTestScenario indices are already registered by integrationpipeline; re-registering would conflict.) Assisted-by: Claude Code Signed-off-by: Josiah England <jengland@redhat.com>
ci-operator
force-pushed
the
fix-releaseplan-application-index
branch
from
fd47d05 to
109414d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
- Coverage 65.83% 65.67% -0.16%
==========================================
Files 63 63
Lines 8409 8411 +2
==========================================
- Hits 5536 5524 -12
- Misses 2235 2249 +14
Partials 638 638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/ok-to-test |
Contributor
Author
|
Folded into #1543 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The snapshot controller's setupCache was missing the spec.application
field index for ReleasePlan, so any tenant still on the Application
(non-ComponentGroup) model couldn't progress past Snapshot creation:
The integrationpipeline controller already registers the matching
*Application variant; this brings the snapshot controller in line.
Introduced by ec4a274 (#1409).
Test plan
make testpasseswith
chains.tekton.dev/signed=true, observed Snapshot -> Release ->release PipelineRun all reach Succeeded;
Index ... does not existno longer appears in the controller log.