Skip to content

docs(#1605): document dual-model architecture#1606

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/1605-document-dual-model
Open

docs(#1605): document dual-model architecture#1606
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/1605-document-dual-model

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Add a "Dual-Model Architecture" subsection to AGENTS.md under Architecture, after the Adapter Pattern section. The new section explains that the service maintains two parallel resource flows (ComponentGroup and Application) and that cross-cutting features must cover both flows until the Application model is fully deprecated. It references key dual-path files and the TODO comment pattern used to mark Application-model code paths.


Closes #1605

Post-script verification

  • Branch is not main/master (agent/1605-document-dual-model)
  • Secret scan passed (gitleaks — 554730ae7c1e8b63aa1a33483b980e9f683c6f42..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add a "Dual-Model Architecture" subsection to AGENTS.md
under Architecture, after the Adapter Pattern section.
The new section explains that the service maintains two
parallel resource flows (ComponentGroup and Application)
and that cross-cutting features must cover both flows
until the Application model is fully deprecated. It
references key dual-path files and the TODO comment
pattern used to mark Application-model code paths.

Closes #1605
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:23 PM UTC · Completed 9:32 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] AGENTS.md — This file is under a protected path (AGENTS.md) and requires human approval regardless of automated review outcome. The PR links to issue Document dual-model (Application + ComponentGroup) completeness requirement in AGENTS.md #1605 and explains the rationale for the change (documenting dual-model architecture to help automated reviewers catch completeness bugs). Human reviewers should verify the documentation addition is accurate and appropriate.

Low

  • [technical accuracy] AGENTS.md:46 — The documentation says to look for TODO: remove when we deprecate old application model comments, but the actual TODO comments in the codebase use many different phrasings (at least 12 variants across 50+ occurrences). Only ~1 instance exactly matches the documented string. A developer relying on this exact string would miss the vast majority of Application-model code paths.
    Remediation: Use a broader description such as: "Look for TODO comments referencing deprecation of the application model (search for TODO.*application case-insensitively) to identify Application-model code paths."

  • [Structure and organization] AGENTS.md:40 — The new "Dual-Model Architecture" subsection is inserted between "Adapter Pattern" and "Resource Loading", interrupting the logical flow between these two foundational pattern descriptions. Consider placing it after "Resource Loading" or within "Additional Key Patterns".

  • [Formatting consistency] AGENTS.md:42 — The new paragraph is denser than existing Architecture subsections (which use 1-2 concise sentences). The single paragraph packs multiple parenthetical code examples and em-dash clauses. Consider breaking into 2-3 shorter sentences to match the established terse style.


Labels: PR modifies documentation (AGENTS.md)

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment documentation Improvements or additions to documentation labels Jun 25, 2026
@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.78%. Comparing base (554730a) to head (66fbb28).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
+ Coverage   73.58%   73.78%   +0.20%     
==========================================
  Files          70       70              
  Lines        9377     9377              
==========================================
+ Hits         6900     6919      +19     
+ Misses       1777     1762      -15     
+ Partials      700      696       -4     
Flag Coverage Δ
e2e-tests 45.01% <ø> (+0.31%) ⬆️
unit-tests 66.73% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 9 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554730a...66fbb28. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirgim dirgim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasemAlem

Copy link
Copy Markdown
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation requires-manual-review Review requires human judgment size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document dual-model (Application + ComponentGroup) completeness requirement in AGENTS.md

3 participants