inttests/build: make non-deterministic test pass#92
Open
chmeliik wants to merge 1 commit intokonflux-ci:mainfrom
Open
inttests/build: make non-deterministic test pass#92chmeliik wants to merge 1 commit intokonflux-ci:mainfrom
chmeliik wants to merge 1 commit intokonflux-ci:mainfrom
Conversation
In c77c517, the assumption was that when the containerfile has duplicate stages, FROM instructions match the last stage with the same name. This assumption was not quite correct: it appears that the behavior is not deterministic. Sometimes, the test fails because buildah decides to use the first stage1 instead of the second, and then the expected labels don't match. We have no way to fix label injection to match buildah in this case, since we have to determine the labels ahead of time and we can't guess which of the stages buildah will choose to use. This will be a bug until the upstream buildah issue (see c77c517) is fixed. Drop the duplicate stage1 from the test until that happens so that we don't have failing tests. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In c77c517, the assumption was that when the containerfile has duplicate stages, FROM instructions match the last stage with the same name.
This assumption was not quite correct: it appears that the behavior is not deterministic. Sometimes, the test fails because buildah decides to use the first stage1 instead of the second, and then the expected labels don't match.
We have no way to fix label injection to match buildah in this case, since we have to determine the labels ahead of time and we can't guess which of the stages buildah will choose to use. This will be a bug until the upstream buildah issue (see c77c517) is fixed.
Drop the duplicate stage1 from the test until that happens so that we don't have failing tests.