feat: RBAC using rover group#47
Merged
Merged
Conversation
msu8
commented
Feb 17, 2026
Contributor
- Add mcp-admin and mcp-viewer role, limiting execute_query for the latter one
- Assign admin role based on devlakemcpadmin rover group
- Search LDAP directory based on username from token for the devlakemcpadmin rover group
Contributor
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 47.54% 50.41% +2.87%
==========================================
Files 27 40 +13
Lines 1424 3003 +1579
Branches 178 408 +230
==========================================
+ Hits 677 1514 +837
- Misses 724 1428 +704
- Partials 23 61 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add mcp-admin and mcp-viewer role, limiting execute_query for the latter one - Assign admin role based on devlakemcpadmin rover group - Search LDAP directory based on username from token for the devlakemcpadmin rover group
Contributor
Author
|
@flacatus I got access to the Snyk and there was a vulnerability in an old version of pyasn1 I explicitly wrote the version and it's still throwing out the alert, even though it supposedly re-run. It makes no sense, I think we can just ignore it. |
flacatus
approved these changes
Feb 25, 2026
Member
|
/ok-to-test |
msu8
added a commit
to msu8/infra-common-deployments
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.