Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add user access routes to all routes #150

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

sahil143
Copy link
Member

@sahil143 sahil143 commented Mar 12, 2025

Fixes

missed adding user routes to index.tsx in #149, which caused 404 errors for all User access pages

Description

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

no visual change

How to test or reproduce?

Test User access page: list, create, edit

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (9be784f) to head (b2475c5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/routes/page-routes/application.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         551      551           
  Lines       21544    21544           
  Branches     5121     5121           
=======================================
  Hits        17356    17356           
  Misses       4163     4163           
  Partials       25       25           
Flag Coverage Δ
unittests 80.56% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/routes/index.tsx 0.00% <ø> (ø)
src/routes/page-routes/application.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be784f...b2475c5. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@marcin-michal marcin-michal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can access User Access page again

Copy link
Collaborator

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UI is working as expected

@JoaoPedroPP
Copy link
Collaborator

/test

@JoaoPedroPP JoaoPedroPP added this pull request to the merge queue Mar 17, 2025
@sahil143 sahil143 removed this pull request from the merge queue due to a manual request Mar 17, 2025
@JoaoPedroPP JoaoPedroPP merged commit 8e8743f into konflux-ci:main Mar 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants