Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): update cve modal #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented Mar 17, 2025

Fixes

https://issues.redhat.com/browse/KFLUXUI-371

Description

CVE Modal is disabled because of validation errors. This PR fixes validation issues

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Screenshot 2025-03-17 at 7 56 42 PM Screenshot 2025-03-17 at 8 51 23 PM Screenshot 2025-03-17 at 9 34 40 PM

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (9be784f) to head (a62743b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...TriggerRelease/AddIssueSection/AddIssueSection.tsx 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         551      551           
  Lines       21544    21553    +9     
  Branches     5121     5126    +5     
=======================================
+ Hits        17356    17365    +9     
  Misses       4163     4163           
  Partials       25       25           
Flag Coverage Δ
unittests 80.56% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/TriggerRelease/AddIssueSection/AddIssueModal.tsx 92.64% <100.00%> (+0.22%) ⬆️
...TriggerRelease/AddIssueSection/AddIssueSection.tsx 87.62% <83.33%> (+0.96%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be784f...a62743b. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant