Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): null check on status of taskrun #30

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

JoaoPedroPP
Copy link
Collaborator

Backport fix(pipeline): null check on status of taskrun to the new repo.

Assure during the migration we move our latest changes.

@gbenhaim
Copy link
Member

/ok-to-test

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (eabc80b) to head (864a4b1).

Files with missing lines Patch % Lines
...seContract/useEnterpriseContractResultFromLogs.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   79.92%   79.94%   +0.02%     
==========================================
  Files         568      568              
  Lines       21329    21331       +2     
  Branches     5285     5029     -256     
==========================================
+ Hits        17048    17054       +6     
+ Misses       4257     4253       -4     
  Partials       24       24              
Flag Coverage Δ
unittests 79.94% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CryptoRodeo
CryptoRodeo previously approved these changes Nov 26, 2024
@JoaoPedroPP
Copy link
Collaborator Author

/retest

@StanislavJochman
Copy link
Member

add test. Otherwise lgtm.

@testcara
Copy link
Member

/lgtm

@JoaoPedroPP
Copy link
Collaborator Author

This coverage can be skipped. Some of the missing lines are } and checking the tests the if statement that codecov complain is working in all situations.

General coverage increase with the addition of the new test case.

@sahil143 sahil143 merged commit 09c1462 into konflux-ci:main Dec 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants