Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXUI-198): component relationship remove button #35

Closed
wants to merge 2 commits into from

Conversation

caugello
Copy link
Contributor

Backports KFLUXBUGS-1197

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (06ab0bb) to head (639f495).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ComponentRelation/utils.ts 10.00% 9 Missing ⚠️
...nents/ComponentRelation/ComponentRelationModal.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   79.70%   79.79%   +0.09%     
==========================================
  Files         564      564              
  Lines       21054    21063       +9     
  Branches     5229     4972     -257     
==========================================
+ Hits        16781    16808      +27     
+ Misses       4248     4231      -17     
+ Partials       25       24       -1     
Flag Coverage Δ
unittests 79.79% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caugello
Copy link
Contributor Author

/retest

@JoaoPedroPP
Copy link
Collaborator

@caugello
Is it possible to cover these missing lines?

@sahil143
Copy link
Member

sahil143 commented Dec 3, 2024

Closing in favor of #45

@sahil143 sahil143 closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants