Skip to content

feat(ISV-5857): Port SBOM merging helper functions#27

Merged
Allda merged 5 commits intokonflux-ci:mainfrom
jakubgryc:ISV-5857
Jun 2, 2025
Merged

feat(ISV-5857): Port SBOM merging helper functions#27
Allda merged 5 commits intokonflux-ci:mainfrom
jakubgryc:ISV-5857

Conversation

@jakubgryc
Copy link
Copy Markdown
Contributor

Ported merger helping functions with few modifications of code style from https://github.com/konflux-ci/build-tasks-dockerfiles/tree/main/sbom-utility-scripts/scripts/merge-sboms-script

Also changed cachi2 references to hermeto

@jakubgryc jakubgryc requested review from Allda and jedinym May 28, 2025 09:04
Comment thread src/mobster/utils/merge_sboms.py Outdated
Comment thread src/mobster/utils/merge_sboms.py Outdated
@jedinym
Copy link
Copy Markdown
Contributor

jedinym commented May 28, 2025

Just noticed this, sorry. I will take a look tomorrow morning.

@jedinym
Copy link
Copy Markdown
Contributor

jedinym commented May 29, 2025

I think the module mobster.sbom.merge would be a better place for this.

Copy link
Copy Markdown
Contributor

@jedinym jedinym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor details, otherwise looks good.

Comment thread src/mobster/utils/merge_sboms.py Outdated
jakubgryc added 5 commits May 30, 2025 00:58
Ported merger helping functions with few modifications of code style
from https://github.com/konflux-ci/build-tasks-dockerfiles/tree/main/sbom-utility-scripts/scripts/merge-sboms-script

Signed-off-by: Jakub Gryc <jgryc@redhat.com>
Signed-off-by: Jakub Gryc <jgryc@redhat.com>
Signed-off-by: Jakub Gryc <jgryc@redhat.com>
Signed-off-by: Jakub Gryc <jgryc@redhat.com>
Signed-off-by: Jakub Gryc <jgryc@redhat.com>
@jakubgryc
Copy link
Copy Markdown
Contributor Author

@Allda @jedinym upon Martin's comment, I changed the module directory to a more suitable one

@jakubgryc jakubgryc requested a review from Allda June 2, 2025 07:56
@Allda Allda added this pull request to the merge queue Jun 2, 2025
Merged via the queue into konflux-ci:main with commit 15e20be Jun 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants