Conversation
Signed-off-by: Martin Jediny <jedinym@proton.me>
jedinym
commented
May 29, 2025
| code, stdout, stderr = await run_async_subprocess( | ||
| cmd, | ||
| env={"DOCKER_CONFIG": authfile}, | ||
| env={"DOCKER_CONFIG": str(Path(authfile).parent)}, |
Contributor
Author
There was a problem hiding this comment.
The DOCKER_CONFIG has to point to directory with config.json, not the file itself.
Contributor
Author
|
Huh, seems like we're missing auth for registry.redhat.io. Sorry for the premature review request 😅 |
Allda
approved these changes
May 30, 2025
Collaborator
Allda
left a comment
Allda
left a comment
There was a problem hiding this comment.
This looks fine, feel free to merge it once you resolve the Konflux secret.
Contributor
Author
|
Secrets added to the-collective-tenant namespace and Bitwarden, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing oras and cosign binaries to Containerfile.