fix(ISV-5982): link to arch-specific images#34
Merged
Conversation
jedinym
changed the title
Allda
reviewed
Jun 2, 2025
| { | ||
| "referenceCategory": "PACKAGE_MANAGER", | ||
| "referenceLocator": "pkg:oci/ubi@sha256:4b4976d86eefeedab6884c9d2923206c6c3c2e2471206f97fd9d7aaaecbc04ac?arch=amd64&repository_url=registry.redhat.io/ubi10-beta/ubi", | ||
| "referenceLocator": "pkg:oci/ubi@sha256:e692418e4cbaf90ca69d05a66403747baa33ee08806650b51fab815ad7fc331f?arch=amd64&repository_url=registry.redhat.io/ubi10-beta/ubi", |
Collaborator
There was a problem hiding this comment.
In order to properly link the index with child manifests, you need to exclude the arch argument from the purl if you use the child digest. The child purls included in the child SBOMs don't have the arch parameter.
Our testing data contained an index SBOM, which had incorrect external references. The SBOM was missing references to arch-specific images. Signed-off-by: Martin Jediny <jedinym@proton.me>
Signed-off-by: Martin Jediny <jedinym@proton.me>
jedinym
force-pushed
the
fix-generate-index
branch
from
e41564e to
afc2b99
Compare
Allda
approved these changes
Jun 3, 2025
ezopezo
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to arch-specific images in image index SBOM. The arch parameters are also removed from the PURLs to ensure that the SBOMs correctly link to the arch-specific image SBOMs. This should be reversed once we have arch parameters in the image SBOMs.
I updated ISV-5858 description to make sure this is handled properly once image SBOMs are generated via mobster.
https://issues.redhat.com/browse/ISV-5982