Skip to content

fix(upload): omit artifacts distribution URL for local --artifact-results folder#91

Merged
jajreidy merged 1 commit intokonflux-ci:mainfrom
jajreidy:fix-local-artifact
Mar 26, 2026
Merged

fix(upload): omit artifacts distribution URL for local --artifact-results folder#91
jajreidy merged 1 commit intokonflux-ci:mainfrom
jajreidy:fix-local-artifact

Conversation

@jajreidy
Copy link
Copy Markdown
Contributor

What
For --artifact-results as a single local folder (no comma), repository setup already skips the artifacts repository. Distribution URL building still added a synthetic artifacts pulp-content entry to the URL map and into pulp_results.json distributions. This change threads skip_artifacts_repo through DistributionManager.get_distribution_urls / PulpHelper.get_distribution_urls and sets it from get_distribution_urls_for_upload_context when artifact_results is folder mode, so artifacts is not listed alongside the skipped repo.

Why
Keeps behavior consistent: no artifacts repo or distribution when results JSON is only written locally.

How to test

git fetch origin
make lint
pre-commit run --all-files
make test
make test-diff-coverage

Notes for reviewers

  • Konflux form url_path,digest_path (comma) is unchanged.
  • CHANGELOG.md updated under [Unreleased]Changed.
  • Files: distribution_manager.py, pulp_helper.py, models/context.py, tests, CHANGELOG.md.

…ults folder

When --artifact-results is a single folder path (no comma), repository
setup already skips the artifacts repo; align distribution URL resolution
so pulp_results.json distributions and upload URL maps do not include a
synthetic artifacts pulp-content entry.

- Add skip_artifacts_repo to DistributionManager and PulpHelper
- Derive skip from UploadContext in get_distribution_urls_for_upload_context
- Document artifact_results folder semantics; extend tests and CHANGELOG

Made-with: Cursor
@jajreidy jajreidy requested a review from a team as a code owner March 26, 2026 13:59
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Mar 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.01%. Comparing base (0e424ea) to head (cb4603e).
⚠️ Report is 108 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   95.53%   97.01%   +1.47%     
==========================================
  Files          70       74       +4     
  Lines        3946     5356    +1410     
==========================================
+ Hits         3770     5196    +1426     
+ Misses        176      160      -16     
Flag Coverage Δ
unit-tests 97.01% <100.00%> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pulp_tool/models/context.py 100.00% <ø> (ø)
pulp_tool/utils/distribution_manager.py 100.00% <100.00%> (ø)
pulp_tool/utils/pulp_helper.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajreidy jajreidy merged commit 91b7bd1 into konflux-ci:main Mar 26, 2026
5 checks passed
@jajreidy jajreidy deleted the fix-local-artifact branch March 26, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants