fix(upload): omit artifacts distribution URL for local --artifact-results folder#91
Merged
jajreidy merged 1 commit intokonflux-ci:mainfrom Mar 26, 2026
Merged
Conversation
…ults folder When --artifact-results is a single folder path (no comma), repository setup already skips the artifacts repo; align distribution URL resolution so pulp_results.json distributions and upload URL maps do not include a synthetic artifacts pulp-content entry. - Add skip_artifacts_repo to DistributionManager and PulpHelper - Derive skip from UploadContext in get_distribution_urls_for_upload_context - Document artifact_results folder semantics; extend tests and CHANGELOG Made-with: Cursor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 95.53% 97.01% +1.47%
==========================================
Files 70 74 +4
Lines 3946 5356 +1410
==========================================
+ Hits 3770 5196 +1426
+ Misses 176 160 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For
--artifact-resultsas a single local folder (no comma), repository setup already skips the artifacts repository. Distribution URL building still added a syntheticartifactspulp-content entry to the URL map and intopulp_results.jsondistributions. This change threadsskip_artifacts_repothroughDistributionManager.get_distribution_urls/PulpHelper.get_distribution_urlsand sets it fromget_distribution_urls_for_upload_contextwhenartifact_resultsis folder mode, soartifactsis not listed alongside the skipped repo.Why
Keeps behavior consistent: no artifacts repo or distribution when results JSON is only written locally.
How to test
git fetch origin make lint pre-commit run --all-files make test make test-diff-coverageNotes for reviewers
url_path,digest_path(comma) is unchanged.CHANGELOG.mdupdated under[Unreleased]→ Changed.distribution_manager.py,pulp_helper.py,models/context.py, tests,CHANGELOG.md.