docs(#206): update stale Go 1.21 references to 1.22#207
docs(#206): update stale Go 1.21 references to 1.22#207fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
go.mod was bumped from 1.21 to 1.22.0 but documentation files were not updated. Fixed all five stale references across CLAUDE.md, AGENTS.md, skills/ci-cd-quirks/SKILL.md, and skills/debugging-cli-locally/SKILL.md to match the current go.mod directive. Also updated the debugging skill's advice since local vs CI Go version mismatch is no longer the primary concern — the Dockerfile UBI9 go-toolset version is. Closes #206
|
🤖 Finished Review · ✅ Success · Started 6:31 PM UTC · Completed 6:39 PM UTC |
ReviewFindingsMedium
Low
Labels: PR exclusively updates documentation files to fix stale Go version references. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| | `GITHUB_TOKEN must be set` | Env var not exported | `export GITHUB_TOKEN="$YOUR_TOKEN"` | | ||
| | `golangci-lint` ignores config | Config is `.golang-ci.yml` not `.golangci.yml` | Use `make lint` or `-c .golang-ci.yml` | | ||
| | Tests pass locally, fail in CI | Go version mismatch (local 1.22, go.mod 1.21) | Avoid 1.22-only features | | ||
| | Tests pass locally, fail in CI | Go version mismatch (local 1.22, go.mod 1.22) | Check Dockerfile UBI9 go-toolset version | |
There was a problem hiding this comment.
[low] technical accuracy in documentation
After the PR, the Cause column reads 'Go version mismatch (local 1.22, go.mod 1.22)' but both versions are identical, so 'mismatch' is self-contradictory. The actual mismatch is between local/CI Go 1.22 and the Dockerfile UBI9 go-toolset which may ship an older version.
Suggested fix: Change the Cause column to something like 'Go version mismatch (local/CI 1.22, UBI9 container may differ)' to accurately describe where the mismatch occurs.
| | Dockerfile | Varies | UBI9 `go-toolset` (version depends on tag) | | ||
|
|
||
| **Consequence**: Code may compile locally with Go 1.22 features but fail in the container if the UBI9 image ships an older Go. Stick to Go 1.21 language features unless `go.mod` is bumped. | ||
| **Consequence**: Code may compile locally with Go 1.22 features but fail in the container if the UBI9 image ships an older Go. Stick to Go 1.22 language features unless `go.mod` is bumped. |
There was a problem hiding this comment.
[low] documentation consistency
The consequence text says 'Stick to Go 1.22 language features unless go.mod is bumped' which is self-consistent, but the same sentence warns UBI9 may ship an older Go — meaning Go 1.22 features could still fail in the container, contradicting the advice.
Suggested fix: Clarify that while go.mod permits 1.22 features, developers should verify the UBI9 go-toolset version supports them before relying on 1.22-specific syntax.
fullsend-ai-review
Bot
added
requires-manual-review
go.mod was bumped from 1.21 to 1.22.0 but documentation files were not updated. Fixed all five stale references across CLAUDE.md, AGENTS.md, skills/ci-cd-quirks/SKILL.md, and skills/debugging-cli-locally/SKILL.md to match the current go.mod directive. Also updated the debugging skill's advice since local vs CI Go version mismatch is no longer the primary concern — the Dockerfile UBI9 go-toolset version is.
Closes #206
Post-script verification
agent/206-fix-go-version-docs)15c51b97cda425dbff6d8556004017266bb63666..HEAD)