fix(KONFLUX-10809): fail incrementer on empty tag list#2328
Open
FilipNikolovski wants to merge 1 commit into
Open
fix(KONFLUX-10809): fail incrementer on empty tag list#2328FilipNikolovski wants to merge 1 commit into
FilipNikolovski wants to merge 1 commit into
Conversation
FilipNikolovski
force-pushed
the
KONFLUX-10809
branch
from
805fc94 to
790cf73
Compare
FilipNikolovski
requested review from
arewm,
gbenhaim,
ralphbean and
twaugh
as code owners
elenagerman
reviewed
Jun 26, 2026
Comment on lines
+103
to
+108
| elif [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repoa"* ]] || \ | ||
| [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repo2"* ]] | ||
| then | ||
| # Genuinely new repos (no manifests yet) - inspect fails | ||
| echo "Error: repository not found" >&2 | ||
| return 1 |
Contributor
There was a problem hiding this comment.
Nice fix!
One small suggestion: consider adding an explicit mock for repo-empty-tags-existing for the skopeo inspect call. Currently it works via the default fallthrough, but making it explicit improves test clarity:
Suggested change
| elif [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repoa"* ]] || \ | |
| [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repo2"* ]] | |
| then | |
| # Genuinely new repos (no manifests yet) - inspect fails | |
| echo "Error: repository not found" >&2 | |
| return 1 | |
| elif [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repo-empty-tags-existing"* ]] | |
| then | |
| # Existing repo that transiently returns empty tags - inspect succeeds | |
| echo '{"config": {"mediaType": "application/vnd.oci.image.config.v1+json"}, "annotations": {}}' | |
| return | |
| elif [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repoa"* ]] || \ | |
| [[ "$*" == "inspect --retry-times 3 --no-tags --raw docker://repo2"* ]] | |
| then | |
| # Genuinely new repos (no manifests yet) - inspect fails | |
| echo "Error: repository not found" >&2 | |
| return 1 |
Contributor
Author
There was a problem hiding this comment.
thanks, updated!
Contributor
|
except for a small proposal: /LGTM |
Add extract_tags() that validates the list-tags response and checks repo existence via skopeo inspect when Tags is empty. If the repo exists but returned no tags, the task now fails instead of producing a potentially destructive increment value. Assisted-by: Claude Code Signed-off-by: Filip Nikolovski <fnikolov@redhat.com>
FilipNikolovski
force-pushed
the
KONFLUX-10809
branch
from
790cf73 to
3888a68
Compare
Contributor
Author
|
/retest |
elenagerman
approved these changes
Jun 29, 2026
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add extract_tags() that validates the list-tags response and checks repo existence via skopeo inspect when Tags is empty. If the repo exists but returned no tags, the task now fails instead of producing a potentially destructive increment value.
Assisted-by: Claude Code
Relevant Jira
https://redhat.atlassian.net/browse/KONFLUX-10809
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>.github/scripts/readme_generator.shand verified the results using.github/scripts/check_readme.shAssisted-By: Cursor