fix(RELEASE-12379): use completion_time instead of buildTimestamp#2329
Draft
theflockers wants to merge 7 commits into
Draft
fix(RELEASE-12379): use completion_time instead of buildTimestamp#2329theflockers wants to merge 7 commits into
theflockers wants to merge 7 commits into
Conversation
theflockers
force-pushed
the
konflux-12379
branch
7 times, most recently
from
41e144e to
cc73756
Compare
Contributor
Author
|
/ok-to-test |
theflockers
force-pushed
the
konflux-12379
branch
5 times, most recently
from
ed554cb to
5bcc094
Compare
Contributor
Author
|
/ok-to-test |
1 similar comment
Contributor
Author
|
/ok-to-test |
theflockers
force-pushed
the
konflux-12379
branch
2 times, most recently
from
46aa511 to
47d33a3
Compare
Contributor
Author
|
/ok-to-test |
theflockers
force-pushed
the
konflux-12379
branch
from
983d43b to
7cacd47
Compare
Contributor
Author
|
/ok-to-test |
theflockers
force-pushed
the
konflux-12379
branch
from
7cacd47 to
c9933bb
Compare
Contributor
Author
|
/ok-to-test |
theflockers
force-pushed
the
konflux-12379
branch
3 times, most recently
from
31ac6b6 to
6544d08
Compare
Contributor
Author
|
/ok-to-test |
theflockers
force-pushed
the
konflux-12379
branch
from
6544d08 to
615321b
Compare
Contributor
Author
|
/ok-to-test |
Replace the buildTimestamp parameter/result with completion_time extracted directly from the IIB build info JSON response. This ensures timestamp consistency with the actual build completion time and adds support for conditional timestamped tags in FBC releases. Changes: - add-fbc-contribution: Extract completion_time from IIB build response (updated_by field), validate it's a 10-digit epoch timestamp, and create target_index_with_timestamp field that avoids duplicate timestamps for hotfix/pre-GA releases - collect-index-images: Use target_index_with_timestamp to conditionally include timestamped tags (2 tags for regular releases, 1 for hotfix/pre-GA) - publish-index-image: Publish both target_index and target_index_with_timestamp tags only when they differ - extract-index-image: Remove unused buildTimestamp parameter - prepare-fbc-snapshot: Update comment to clarify timestamp is arbitrary until build completion - fbc-release pipeline: Remove buildTimestamp parameter passing For regular releases, both v4.14 and v4.14-<timestamp> tags are published. For hotfix/pre-GA releases (which already include timestamps in target_index), only a single tag is published to avoid duplication. This change also fixes RELEASE-2666 by ensuring the timestamped image is properly created and available for signing. All integration tests updated to reflect the new behavior. Assisted-By: Claude Code Signed-off-by: Leandro Mendes <lmendes@redhat.com>
Signed-off-by: Leandro Mendes <lmendes@redhat.com>
Signed-off-by: Leandro Mendes <lmendes@redhat.com>
- inspect-target-index-task: add missing targetIndex parameter to skopeo - collect-index-images: fix IMAGE_DIGESTS handling - Save original digests from IIB build before loop - Reset to original digests at start of each iteration - Inspect base tag only (not timestamped tag) for regular releases - Extract InternalRequest result properly from kubectl - Base tag gets fresh digests, timestamped tag uses original Assisted-By: Claude Signed-off-by: Leandro Mendes <lmendes@redhat.com>
theflockers
force-pushed
the
konflux-12379
branch
from
615321b to
9f12813
Compare
theflockers
force-pushed
the
konflux-12379
branch
from
9f12813 to
97e04a5
Compare
Contributor
Author
|
/ok-to-test |
…images Fixed jq expressions for digest extraction and comparison: - Use jq -r '.[0]' to extract built digest from array - Use jq -r '.digest' to extract current digest from object - Match lowercase 'digest' field from inspect-target-index output Assisted-By: Claude Signed-off-by: Leandro Mendes <lmendes@redhat.com>
Contributor
Author
|
/ok-to-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the buildTimestamp parameter/result with completion_time extracted directly from the IIB build info JSON response. This ensures timestamp consistency with the actual build completion time and adds support for conditional timestamped tags in FBC releases.
Changes:
For regular releases, both v4.14 and v4.14- tags are published. For hotfix/pre-GA releases (which already include timestamps in target_index), only a single tag is published to avoid duplication.
This change also fixes RELEASE-2666 by ensuring the timestamped image is properly created and available for signing.
All integration tests updated to reflect the new behavior.
Assisted-By: Claude Code
Describe your changes
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>.github/scripts/readme_generator.shand verified the results using.github/scripts/check_readme.shAssisted-By: Cursor