Skip to content

fix(RELEASE-1993): fix missing result in update-fbc-catalog#855

Merged
FilipNikolovski merged 1 commit into
konflux-ci:mainfrom
FilipNikolovski:RELEASE-1993-fix
Jul 2, 2026
Merged

fix(RELEASE-1993): fix missing result in update-fbc-catalog#855
FilipNikolovski merged 1 commit into
konflux-ci:mainfrom
FilipNikolovski:RELEASE-1993-fix

Conversation

@FilipNikolovski

Copy link
Copy Markdown
Contributor

Always write the iibLog result file even when the log URL is empty, write all five result files on early failure paths, and fetch full build details for reused builds so the logs field is populated.

Assisted-by: Claude Code

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (0d7a7ad) to head (c418e2d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          72       72           
  Lines        7111     7118    +7     
=======================================
+ Hits         6802     6809    +7     
  Misses        309      309           
Flag Coverage Δ
unit-tests 95.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cripts/python/tasks/internal/update_fbc_catalog.py 84.77% <100.00%> (+0.32%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7a7ad...c418e2d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

seanconroy2021
seanconroy2021 previously approved these changes Jun 29, 2026

@seanconroy2021 seanconroy2021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread scripts/python/tasks/internal/update_fbc_catalog.py Outdated
@ach912

ach912 commented Jul 2, 2026

Copy link
Copy Markdown

Production Approval Record

Field Value
Action APPROVED
Reviewer @ach912
Timestamp 2026-07-02T10:58:42.911Z

Approved

Always write the iibLog result file even when the log URL is empty,
write all five result files on early failure paths, and fetch full
build details for reused builds so the logs field is populated.

Assisted-by: Claude Code
Signed-off-by: Filip Nikolovski <fnikolov@redhat.com>
@FilipNikolovski FilipNikolovski added this pull request to the merge queue Jul 2, 2026
Merged via the queue into konflux-ci:main with commit 86975a4 Jul 2, 2026
27 checks passed
@FilipNikolovski FilipNikolovski deleted the RELEASE-1993-fix branch July 2, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants