Skip to content

feat(RELEASE-2482): convert collect-slack-notification-params to python#862

Open
FilipNikolovski wants to merge 1 commit into
konflux-ci:mainfrom
FilipNikolovski:RELEASE-2482
Open

feat(RELEASE-2482): convert collect-slack-notification-params to python#862
FilipNikolovski wants to merge 1 commit into
konflux-ci:mainfrom
FilipNikolovski:RELEASE-2482

Conversation

@FilipNikolovski

Copy link
Copy Markdown
Contributor

Convert the collect-slack-notification-params managed task to python.

Assisted-by: Claude Code

@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.68%. Comparing base (586cbe7) to head (f4446e8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tasks/managed/collect_slack_notification_params.py 98.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   95.63%   95.68%   +0.05%     
==========================================
  Files          71       73       +2     
  Lines        7078     7186     +108     
==========================================
+ Hits         6769     6876     +107     
- Misses        309      310       +1     
Flag Coverage Δ
unit-tests 95.68% <98.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tasks/managed/collect_slack_notification_params.py 98.66% <98.66%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586cbe7...f4446e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

querti
querti previously approved these changes Jul 1, 2026

@querti querti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, I leave it up to you to decide if it's worthwhile to address it.

Comment thread scripts/python/tasks/managed/collect_slack_notification_params.py
querti
querti previously approved these changes Jul 1, 2026
Comment thread .coverage Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistakenly added?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've also added this file to gitignore.

Comment thread scripts/python/tasks/managed/collect_slack_notification_params.py Outdated
Comment thread scripts/python/tasks/managed/collect_slack_notification_params.py Outdated
Convert the collect-slack-notification-params
managed task to python.

Assisted-by: Claude Code
Signed-off-by: Filip Nikolovski <fnikolov@redhat.com>

@ach912 ach912 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants