fix(deps): update module sigs.k8s.io/controller-runtime to v0.24.1#1542
fix(deps): update module sigs.k8s.io/controller-runtime to v0.24.1#1542red-hat-konflux[bot] wants to merge 1 commit into
Conversation
|
|
Go Test on Pull Requests / Check docker build (pull_request) |
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
from
4327b6c to
7cb0545
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
deleted the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
12 times, most recently
from
c7c506d to
f02eba4
Compare
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
2 times, most recently
from
946dfb9 to
fcd872a
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x
branch
4 times, most recently
from
c2ab09d to
7bbeff0
Compare
|
🤖 Finished Review · ✅ Success · Started 2:45 PM UTC · Completed 2:51 PM UTC |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 8:08 PM UTC · Completed 8:14 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 1:16 PM UTC · Completed 1:22 PM UTC |
|
🤖 Finished Review · ✅ Success · Started 8:58 PM UTC · Completed 9:05 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 8:30 PM UTC · Completed 8:37 PM UTC |
|
🤖 Finished Review · ✅ Success · Started 2:00 PM UTC · Completed 2:07 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 5:46 PM UTC · Completed 5:53 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Retro · ✅ Success · Started 1:21 AM UTC · Completed 1:26 AM UTC |
Retro: PR #1542 — Repeated review agent runs on broken bot dependency bumpThis PR was a single-line What happened: Over 59 days, the review agent ran 17 times with essentially identical findings each time, plus 2 retro runs. The PR was eventually autoclosed without being merged. A previous retro on June 22 already identified all root causes. No new proposals. Every improvement opportunity from this workflow is already tracked by open issues in
This PR is a strong motivating example for prioritizing the circuit breaker (#902) and per-PR review budget (#2587/#2599) issues — any one of those would have prevented most of the 17 redundant review runs. |
|
🤖 Finished Review · ✅ Success · Started 5:26 AM UTC · Completed 5:36 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 11:25 AM UTC · Completed 11:33 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 3:34 PM UTC · Completed 3:41 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 10:45 AM UTC · Completed 10:54 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ❌ Failure · Started 4:38 PM UTC · Completed 4:45 PM UTC |
|
🤖 Finished Review · ✅ Success · Started 2:29 PM UTC · Completed 2:39 PM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 1:35 AM UTC · Completed 1:39 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
🤖 Finished Review · ✅ Success · Started 2:40 PM UTC · Completed 2:46 PM UTC |
| k8s.io/client-go v11.0.0+incompatible | ||
| knative.dev/pkg v0.0.0-20260622140654-39ebae2ee2dc | ||
| sigs.k8s.io/controller-runtime v0.23.3 | ||
| sigs.k8s.io/controller-runtime v0.24.1 |
There was a problem hiding this comment.
[medium] API contract violation
controller-runtime v0.24.1 is a minor version bump from v0.23.3. The project imports controller-runtime across 60+ source files. Since the PR is labeled breaking-change and is a draft, compilation and test verification are essential before merge.
Suggested fix: Ensure CI passes (compilation + tests) before merging. If compilation fails, update call sites to match the new controller-runtime API.
| k8s.io/client-go v11.0.0+incompatible | ||
| knative.dev/pkg v0.0.0-20260622140654-39ebae2ee2dc | ||
| sigs.k8s.io/controller-runtime v0.23.3 | ||
| sigs.k8s.io/controller-runtime v0.24.1 |
There was a problem hiding this comment.
[low] scope-creep-risk
Minor version bump (0.23 to 0.24) of core Kubernetes controller framework may introduce API changes or behavioral differences beyond a simple patch-level fix.
2 participants
This PR contains the following updates:
v0.23.3→v0.24.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.24.1Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.24.0...v0.24.1
v0.24.0Compare Source
🐛 Bug Fixes
🌱 Others
StartLoggingfor event debug logs (#3451)🌱 CI & linters
tools/setup-envtestsubmodule (#3476)📖 Additionally, there has been 1 contribution to our documentation. (#3477)
Dependencies
Added
Changed
8a7402a→944ab1f078029d→bd525daa0af3ef→8636f87200df99→8636f87f2248ac589584f→43fb72cbc988d5→b8788abRemoved
9bdfabeThanks to all our contributors! 😊
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.