Skip to content

chore(deps): update module github.com/golang-jwt/jwt/v4 to v5#934

Draft
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x
Draft

chore(deps): update module github.com/golang-jwt/jwt/v4 to v5#934
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/golang-jwt/jwt/v4 v4.5.2v5.3.1 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

golang-jwt/jwt (github.com/golang-jwt/jwt/v4)

v5.3.1

Compare Source

What's Changed

🔐 Features
👒 Dependencies

New Contributors

Full Changelog: golang-jwt/jwt@v5.3.0...v5.3.1

v5.3.0

Compare Source

This release is almost identical to to v5.2.3 but now correctly indicates Go 1.21 as minimum requirement.

What's Changed

Full Changelog: golang-jwt/jwt@v5.2.3...v5.3.0

v5.2.3

Compare Source

What's Changed

New Contributors

Full Changelog: golang-jwt/jwt@v5.2.2...v5.2.3

v5.2.2

Compare Source

What's Changed

New Contributors

Full Changelog: golang-jwt/jwt@v5.2.1...v5.2.2

v5.2.1

Compare Source

What's Changed

New Contributors

Full Changelog: golang-jwt/jwt@v5.2.0...v5.2.1

v5.2.0

Compare Source

What's Changed

New Contributors

Full Changelog: golang-jwt/jwt@v5.1.0...v5.2.0

v5.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: golang-jwt/jwt@v5.0.0...v5.1.0

v5.0.0

Compare Source

🚀 New Major Version v5 🚀

It's finally here, the release you have been waiting for! We don't take breaking changes lightly, but the changes outlined below were necessary to address some of the challenges of the previous API. A big thanks for @​mfridman for all the reviews, all contributors for their commits and of course @​dgrijalva for the original code. I hope we kept some of the spirit of your original v4 branch alive in the approach we have taken here.
~@​oxisto, on behalf of @​golang-jwt/maintainers

Version v5 contains a major rework of core functionalities in the jwt-go library. This includes support for several validation options as well as a re-design of the Claims interface. Lastly, we reworked how errors work under the hood, which should provide a better overall developer experience.

Starting from v5.0.0, the import path will be:

"github.com/golang-jwt/jwt/v5"

For most users, changing the import path should suffice. However, since we intentionally changed and cleaned some of the public API, existing programs might need to be updated. The following sections describe significant changes and corresponding updates for existing programs.

Parsing and Validation Options

Under the hood, a new validator struct takes care of validating the claims. A long awaited feature has been the option to fine-tune the validation of tokens. This is now possible with several ParserOption functions that can be appended to most Parse functions, such as ParseWithClaims. The most important options and changes are:

  • Added WithLeeway to support specifying the leeway that is allowed when validating time-based claims, such as exp or nbf.
  • Changed default behavior to not check the iat claim. Usage of this claim is OPTIONAL according to the JWT RFC. The claim itself is also purely informational according to the RFC, so a strict validation failure is not recommended. If you want to check for sensible values in these claims, please use the WithIssuedAt parser option.
  • Added WithAudience, WithSubject and WithIssuer to support checking for expected aud, sub and iss.
  • Added WithStrictDecoding and WithPaddingAllowed options to allow previously global settings to enable base64 strict encoding and the parsing of base64 strings with padding. The latter is strictly speaking against the standard, but unfortunately some of the major identity providers issue some of these incorrect tokens. Both options are disabled by default.

Changes to the Claims interface

Complete Restructuring

Previously, the claims interface was satisfied with an implementation of a Valid() error function. This had several issues:

  • The different claim types (struct claims, map claims, etc.) then contained similar (but not 100 % identical) code of how this validation was done. This lead to a lot of (almost) duplicate code and was hard to maintain
  • It was not really semantically close to what a "claim" (or a set of claims) really is; which is a list of defined key/value pairs with a certain semantic meaning.

Since all the validation functionality is now extracted into the validator, all VerifyXXX and Valid functions have been removed from the Claims interface. Instead, the interface now represents a list of getters to retrieve values with a specific meaning. This allows us to completely decouple the validation logic with the underlying storage representation of the claim, which could be a struct, a map or even something stored in a database.

type Claims interface {
	GetExpirationTime() (*NumericDate, error)
	GetIssuedAt() (*NumericDate, error)
	GetNotBefore() (*NumericDate, error)
	GetIssuer() (string, error)
	GetSubject() (string, error)
	GetAudience() (ClaimStrings, error)
}
Supported Claim Types and Removal of StandardClaims

The two standard claim types supported by this library, MapClaims and RegisteredClaims both implement the necessary functions of this interface. The old StandardClaims struct, which has already been deprecated in v4 is now removed.

Users using custom claims, in most cases, will not experience any changes in the behavior as long as they embedded RegisteredClaims. If they created a new claim type from scratch, they now need to implemented the proper getter functions.

Migrating Application Specific Logic of the old Valid

Previously, users could override the Valid method in a custom claim, for example to extend the validation with application-specific claims. However, this was always very dangerous, since once could easily disable the standard validation and signature checking.

In order to avoid that, while still supporting the use-case, a new ClaimsValidator interface has been introduced. This interface consists of the Validate() error function. If the validator sees, that a Claims struct implements this interface, the errors returned to the Validate function will be appended to the regular standard validation. It is not possible to disable the standard validation anymore (even only by accident).

Usage examples can be found in example_test.go, to build claims structs like the following.

// MyCustomClaims includes all registered claims, plus Foo.
type MyCustomClaims struct {
	Foo string `json:"foo"`
	jwt.RegisteredClaims
}

// Validate can be used to execute additional application-specific claims
// validation.
func (m MyCustomClaims) Validate() error {
	if m.Foo != "bar" {
		return errors.New("must be foobar")
	}

	return nil
}

Changes to the Token and Parser struct

The previously global functions DecodeSegment and EncodeSegment were moved to the Parser and Token struct respectively. This will allow us in the future to configure the behavior of these two based on options supplied on the parser or the token (creation). This also removes two previously global variables and moves them to parser options WithStrictDecoding and WithPaddingAllowed.

In order to do that, we had to adjust the way signing methods work. Previously they were given a base64 encoded signature in Verify and were expected to return a base64 encoded version of the signature in Sign, both as a string. However, this made it necessary to have DecodeSegment and EncodeSegment global and was a less than perfect design because we were repeating encoding/decoding steps for all signing methods. Now, Sign and Verify operate on a decoded signature as a []byte, which feels more natural for a cryptographic operation anyway. Lastly, Parse and SignedString take care of the final encoding/decoding part.

In addition to that, we also changed the Signature field on Token from a string to []byte and this is also now populated with the decoded form. This is also more consistent, because the other parts of the JWT, mainly Header and Claims were already stored in decoded form in Token. Only the signature was stored in base64 encoded form, which was redundant with the information in the Raw field, which contains the complete token as base64.

type Token struct {
	Raw       string                 // Raw contains the raw token
	Method    SigningMethod          // Method is the signing method used or to be used
	Header    map[string]interface{} // Header is the first segment of the token in decoded form
	Claims    Claims                 // Claims is the second segment of the token in decoded form
	Signature []byte                 // Signature is the third segment of the token in decoded form
	Valid     bool                   // Valid specifies if the token is valid
}

Most (if not all) of these changes should not impact the normal usage of this library. Only users directly accessing the Signature field as well as developers of custom signing methods should be affected.

What's Changed

New Contributors

Full Changelog: golang-jwt/jwt@v4.5.0...v5.0.0


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@seanconroy2021

Copy link
Copy Markdown
Member

@seanconroy2021 seanconroy2021 marked this pull request as draft October 7, 2025 12:24
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch from 8445705 to 266ebed Compare October 7, 2025 12:33
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch from 266ebed to 038bf61 Compare October 16, 2025 04:35
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed Oct 27, 2025
@red-hat-konflux red-hat-konflux Bot closed this Oct 27, 2025
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch October 27, 2025 04:38
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 Oct 27, 2025
@red-hat-konflux red-hat-konflux Bot reopened this Oct 27, 2025
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch from ff7bcf3 to 038bf61 Compare October 27, 2025 08:31
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed Nov 7, 2025
@red-hat-konflux red-hat-konflux Bot closed this Nov 7, 2025
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 Nov 7, 2025
@red-hat-konflux red-hat-konflux Bot reopened this Nov 7, 2025
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch from 3b28e93 to 038bf61 Compare November 7, 2025 16:40
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed Nov 10, 2025
@red-hat-konflux red-hat-konflux Bot closed this Nov 10, 2025
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 Nov 11, 2025
@red-hat-konflux red-hat-konflux Bot reopened this Nov 11, 2025
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch from 42d48b3 to 038bf61 Compare November 11, 2025 01:16
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed Nov 17, 2025
@red-hat-konflux red-hat-konflux Bot closed this Nov 17, 2025
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 Nov 18, 2025
@red-hat-konflux red-hat-konflux Bot reopened this Nov 18, 2025
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-golang-jwt-jwt-v4-5.x branch from 017f3e2 to 038bf61 Compare November 18, 2025 05:31
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed Nov 21, 2025
@red-hat-konflux red-hat-konflux Bot closed this Nov 21, 2025
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 - autoclosed chore(deps): update module github.com/golang-jwt/jwt/v4 to v5 Nov 21, 2025
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #934 — Duplicate retro on Renovate bot jwt/v4→v5 bump

This is a duplicate retro. A previous retro ran on this same PR on Jun 20, 2026 and posted comprehensive findings. This second retro (Jun 21) confirms all prior conclusions and demonstrates the exact problem described by #2401.

What happened: Renovate bot opened a fundamentally invalid PR (swapping golang-jwt/jwt/v4 with jwt/v5 in go.mod without running go mod tidy, while transitive deps still require v4). A human moved it to draft in Oct 2025. Eight months later, the review agent ran 10 times over 5 days (Jun 15–20, 2026), all producing identical CHANGES_REQUESTED verdicts with the same diagnosis. A retro ran on Jun 20 and identified the waste. The PR was auto-closed on Jun 21. Then this second retro was dispatched.

No new proposals. All improvement opportunities are already covered by open upstream issues:

  • #1715 — Skip review dispatch when PR is in draft state (would have prevented all 10 reviews)
  • #2461 — Skip retro dispatch for autoclosed bot-authored PRs (would have prevented this retro)
  • #2401 — Deduplicate retro runs on the same PR (would have prevented this duplicate retro)
  • #1013 — Deduplicate review findings across iterations on the same PR
  • #1357 — Enable cancel-in-progress for review dispatches on the same PR
  • #1355 — Skip re-review when bot dep-bump PR is rebased with no semantic change

Implementing #1715 alone would have eliminated all 10 review runs and both retro runs. #2401 would have prevented this duplicate retro. These represent the highest-priority cluster for reducing token waste on bot PRs.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:25 PM UTC · Completed 10:32 PM UTC
Commit: 218f229 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:38 AM UTC · Completed 10:44 AM UTC
Commit: 218f229 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:49 PM UTC · Completed 2:56 PM UTC
Commit: 7acff03 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:11 PM UTC · Completed 8:18 PM UTC
Commit: 0d0162a · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:21 PM UTC · Completed 1:29 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:02 PM UTC · Completed 9:08 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 24, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:34 PM UTC · Completed 8:48 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 26, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:03 PM UTC · Completed 2:12 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 26, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:51 PM UTC · Completed 6:00 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:29 AM UTC · Completed 11:37 AM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:38 PM UTC · Completed 3:46 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:49 AM UTC · Completed 10:57 AM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ❌ Failure · Started 4:43 PM UTC · Completed 4:49 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:24 PM UTC · Completed 10:32 PM UTC
Commit: ec21706 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 1, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:31 PM UTC · Completed 2:41 PM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:38 AM UTC · Completed 1:45 AM UTC
Commit: ec21706 · View workflow run →

fullsend-ai-review[bot]

This comment was marked as outdated.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:44 PM UTC · Completed 2:50 PM UTC
Commit: ec21706 · View workflow run →

Comment thread go.mod
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
github.com/gobwas/glob v0.2.3 // indirect
github.com/golang-jwt/jwt/v4 v4.5.2 // indirect
github.com/golang-jwt/jwt/v5 v5.3.1 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] api-contract

The PR replaces golang-jwt/jwt/v4 with jwt/v5. The primary transitive consumer, ghinstallation/v2 v2.19.0, migrated to jwt/v5 starting around v2.12.0, so the upgrade is compatible. The absence of go.sum changes in the diff is expected for a Renovate bot PR where go.sum diffs are often omitted from the review view, not necessarily missing from the commit.

Suggested fix: Verify the CI pipeline passes (go mod tidy, go build ./..., go test ./...) before merging. This is standard practice and the draft status suggests it is still being validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code ready-for-merge All reviewers approved — ready to merge Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants