Skip to content

Feat add accepted mime types in import action - #133

Open
fadilAndrian wants to merge 2 commits into
mainfrom
fix/import-accepted-mime-types
Open

Feat add accepted mime types in import action#133
fadilAndrian wants to merge 2 commits into
mainfrom
fix/import-accepted-mime-types

Conversation

@fadilAndrian

@fadilAndrian fadilAndrian commented Oct 3, 2023

Copy link
Copy Markdown

fix(ImportAction.php): add support for custom acceptedMimeTypes in the FileUpload component to allow for more flexible file type validation

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Filament Import?
Put an x in the boxes that apply

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

fadilAndrian and others added 2 commits October 3, 2023 15:19
fix(ImportAction.php): add support for custom acceptedMimeTypes in the FileUpload component to allow for more flexible file type validation
@fadilAndrian
fadilAndrian requested a review from frankyso October 3, 2023 08:20
@tiagof

tiagof commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

Hi.
First of all let me say i'm not the owner not a maintainer of this project, nevertheless here are my 2 cents:

  • don't add any IDE specific files to the repo. In this case, remove .idea/
  • keep the project's code style. If it uses null | Closure, don't go replacing it with ?Closure. - I know this is (pobably) automatically done by your IDE...don't let it.
  • same goes for reordering use (traits), although not so "critical"
  • make sure you add tests for every added feature.

Finally, thanks for this PR, hope the feature get's added since I'll have use for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants