Skip to content

Feat Notification handling - #146

Open
amoradel wants to merge 8 commits into
konnco:filament3from
amoradel:filament3
Open

Feat Notification handling#146
amoradel wants to merge 8 commits into
konnco:filament3from
amoradel:filament3

Conversation

@amoradel

@amoradel amoradel commented Nov 30, 2023

Copy link
Copy Markdown

Proposed changes

  • Notification handling
    • When there are several rows (lines) that have the same error, it is grouped and displayed in a single notification.
    • Importing with skipped rows displays differently.

Types of changes

What types of changes does your code introduce to Filament Import?
Put an x in the boxes that apply

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@amoradel amoradel changed the title Notification handling Feat Notification handling Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant