JSON: handle required and missing fields #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quired = true), otherwise handle missing properties like explicit "null" fields.
konsoletyper
requested changes
Jan 14, 2020
| static native boolean isNull(Node node); | ||
|
|
||
| @JSBody(params = { "node" }, script = "return node === undefined;") |
There was a problem hiding this comment.
IMO, it's better to use void 0 instead of undefined.
| @@ -32,9 +32,12 @@ | |||
| @JSBody(params = { "node" }, script = "return typeof node == 'string';") | |||
| static native boolean isString(Node node); | |||
|
|
|||
| @JSBody(params = { "node" }, script = "return node === null;") | |||
| @JSBody(params = { "node" }, script = "return node === null || node === undefined;") | |||
There was a problem hiding this comment.
Please, remove node === undefined check from this method, that's incorrect
There was a problem hiding this comment.
OK, but now I had to add a check to not run the serializer for nullable values on the missing value
| @@ -498,11 +498,27 @@ private void emitField(PropertyInformation property, Value<Object> target, | |||
| Type type = javaField.getGenericType(); | |||
|
|
|||
| String propertyName = property.outputName; | |||
| Value<Node> jsonValue = emit(() -> node.get().get(propertyName)); | |||
| Value<Node> jsonValue = readProperty(property, node, propertyName); | |||
| Value<Object> value = convert(jsonValue, context, type, field); | |||
| emit(() -> field.set(target.get(), value.get())); | |||
There was a problem hiding this comment.
I guess you should check if property presents in JSON and only if it does, call field.set.
…on a missing value, only set the field if the value isn't missing (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to handle missing and required properties when deserializing JSON.
This adds an explicit exception when a required property is missing and otherwise treats all missing fields like "null" fields.