- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
Use biome and format all files #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
     Merged
                    Changes from 6 commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1122c28
              
                Use biome and format all files
              
              
                JiriLojda fec56ac
              
                Comment out advancedDiff formatting in tests and wait for Biome 2
              
              
                JiriLojda e5c024c
              
                Update MAPI SDK to fix types in tests
              
              
                JiriLojda 4be988b
              
                Render only 3 levels of terms
              
              
                JiriLojda ab78014
              
                Add test for taxonomy terms depth in visual diff
              
              
                JiriLojda 9b900f3
              
                Add schema to biome.json
              
              
                JiriLojda b53da25
              
                2.3.11
              
              
                JiriLojda e74c437
              
                Format package.json properly
              
              
                JiriLojda File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,33 +1,50 @@ | ||
| { | ||
| "extends": [ | ||
| "@kontent-ai" | ||
| ], | ||
|  | ||
| "overrides": [ | ||
| { | ||
| "files": ["src/**/*.ts"], | ||
| "excludedFiles": ["src/log.ts"], | ||
| "rules": { | ||
| "no-restricted-syntax": [ | ||
| "error", | ||
| { | ||
| "selector": "MemberExpression[object.name='console'][property.name=/^(log|warn|error|info|trace)$/]", | ||
| "message": "Don't log into the console directly. Use one of the functions from the log.ts file (logInfo, logWarning, logError) to ensure provided --logLevel is respected." | ||
| }, | ||
| { | ||
| "selector": "CallExpression[callee.name='createManagementClient']", | ||
| "message": "Use the createClient function from src/utils/client.ts instead." | ||
| }, | ||
| { | ||
| "selector": "NewExpression[callee.name='ManagementClient']", | ||
| "message": "Use the createClient function from src/utils/client.ts instead." | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
|  | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "project": ["tsconfig.json", "tsconfig.tests.jsonc", "tsconfig.configs.jsonc"] | ||
| "project": ["./tsconfig.json", "./tsconfig.tests.jsonc"], | ||
| "ecmaFeatures": { | ||
| "jsx": true | ||
| }, | ||
| "sourceType": "module" | ||
| }, | ||
| "settings": { | ||
| "react": { | ||
| "version": "detect" | ||
| } | ||
| }, | ||
| "plugins": ["@typescript-eslint"], | ||
| "extends": ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended"], | ||
| "rules": { | ||
| "no-loop-func": "off", | ||
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": "error", | ||
| "@typescript-eslint/no-loop-func": "error", | ||
| "@typescript-eslint/no-redundant-type-constituents": "error", | ||
| "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error", | ||
| "@typescript-eslint/no-unnecessary-qualifier": "error", | ||
| "@typescript-eslint/no-unnecessary-condition": "error", | ||
| "@typescript-eslint/prefer-includes": "error", | ||
| "@typescript-eslint/prefer-return-this-type": "error", | ||
| "@typescript-eslint/prefer-string-starts-ends-with": "error", | ||
| "@typescript-eslint/prefer-for-of": "error", | ||
| "@typescript-eslint/prefer-function-type": "error", | ||
| "@typescript-eslint/prefer-optional-chain": "error", | ||
| "@typescript-eslint/prefer-reduce-type-parameter": "error", | ||
| "@typescript-eslint/prefer-ts-expect-error": "error", | ||
| "no-restricted-syntax": [ | ||
| "error", | ||
| { | ||
| "selector": "MemberExpression[object.name='console'][property.name=/^(log|warn|error|info|trace)$/]", | ||
| "message": "Don't log into the console directly. Use one of the functions from the log.ts file (logInfo, logWarning, logError) to ensure provided --logLevel is respected." | ||
| }, | ||
| { | ||
| "selector": "CallExpression[callee.name='createManagementClient']", | ||
| "message": "Use the createClient function from src/utils/client.ts instead." | ||
| }, | ||
| { | ||
| "selector": "NewExpression[callee.name='ManagementClient']", | ||
| "message": "Use the createClient function from src/utils/client.ts instead." | ||
| } | ||
| ] | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "$schema": "./node_modules/@biomejs/biome/configuration_schema.json", | ||
| "extends": ["@kontent-ai/biome-config/base"] | ||
| } | ||
This file was deleted.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JiriLojda I would also add schema link for intellisense within the config:
"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll add it