-
Notifications
You must be signed in to change notification settings - Fork 32
Modernize the Delivery SDK (v17) #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e753493
a3a391a
30b9d0a
5c5340b
281a112
39dbc81
4b209d3
f22d4d3
3b182e8
3de8f4e
8ee97c4
0218b85
1fb9c1e
44c456f
9e3925b
9f99521
1a74bfb
8330e1b
7e40777
724d3fb
812e64e
9feb664
33af781
d970509
a9bb07f
f807596
011324c
86cc9e8
4df616e
40e17ff
cc869b4
75899d3
b7a4a07
471b56a
bbf9cc9
59fdc1d
49606da
bf0a266
15d1512
da21b0e
a907a89
901687f
48b0549
95a1920
1770b95
da4f3e6
57b6880
4b0c0b9
c4793fa
6764d01
25bec91
3568ecd
c54020e
e9be714
fd1ea57
9830127
ed9407b
eb5b61f
928705f
f0b50ab
a6b7273
fd60b3f
69ef53e
5ed32bc
79229b6
01c2ccb
ff1da7e
1a20f80
2194c64
53970f8
adb3d28
61d2743
3e88c66
019fde6
93ecbc5
c233f87
6a36b99
f51f814
1afc4aa
378c14b
cff45a2
3958b02
709d9ee
b4b59d1
5f35e7e
6efc47c
9211658
68808e9
00fe6aa
d450c70
ca4c9fb
a5d5a30
f68294d
2f4ef23
525f7c9
ee2f3ac
f036786
832ad54
0b312bb
5db9947
4eb0aa7
51e3935
b111947
36c4d8f
33fdad0
7253246
8894d29
e895895
1cc0c72
9340692
2d4e47a
7cbbafc
3956836
1e8f2ae
8ae5354
bb7c96f
9b7f759
37a67af
e67e43e
77787c0
d05e7aa
231ed53
f237d2e
5250907
aa4f5f7
7518f9f
63f64fe
4495e8f
e38c13e
a094471
9912b79
88b56d6
80278f1
61e8200
a003d0b
df0fe91
39b9fb0
623b724
a53152d
cc6ed9b
c2eae2e
de5a5cf
a3345e3
44602c2
daefc8f
ff25e94
45288c7
f412cb5
6a7aef6
506cd9b
04f33ce
79bd834
ab486e6
c2b509f
229b04c
b20cd27
ebf8e02
78673ab
6c4f865
591e9b3
93ed44c
c445dc1
1920ede
f4b9e13
f235070
7feaf23
48b3f9b
92a362c
eb015e1
ddb1da8
450bd61
72278db
58939cb
45fabff
5485344
4feb267
d5dea35
355ca67
f529e5d
8d3ac13
f4e15c4
ddfeeae
e69f5f9
4913dc2
47ec42a
6aca2d9
7f529f0
7a7db2b
7bd541e
fa76b63
a6c1714
f4bfdef
ab83f34
cf535c7
9308a05
ac6c641
4955034
508fcce
d8b3e82
d48d445
9b2021d
b8f54bc
3ab2180
388c98d
803d72d
f4313ec
39a1b64
f1df231
9dd621f
be6ac78
6a83ffd
1ab6cfa
3714d27
2aa955f
603309f
146f9b1
be91994
bb5566b
0e8f484
8a4966b
edb78c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "hooks": {} | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Name of Kontent.ai project: SDK Integration tests | ||
|
|
||
| INTEGRATION_ENVIRONMENT_ID=6bdd84fc-f71e-01a0-0ba6-79ce07af7f9b | ||
| # INTEGRATION_DELIVERY_HOST=deliver.kontent.ai | ||
| # INTEGRATION_DELIVERY_PROTOCOL=https |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * text eol=lf |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Users referenced in this file will automatically be requested as reviewers for PRs that modify the given paths. | ||
| # See https://help.github.com/articles/about-code-owners/ | ||
|
|
||
| * @IvanKiral @Enngage @kontent-ai/javascript-maintainers | ||
| * @Enngage @kontent-ai/javascript-maintainers | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall we get rid of javascript maintaners team and use developer-relations here? :) |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Lint & Build | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is no main branch - unless you rename master |
||
| pull_request: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there are newer versions of those checkout i believe. something like v7. check also the other workflows |
||
| - name: Use Node.js from .nvmrc file | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm run build | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| permissions: | ||
| # Required for OIDC publishing | ||
| id-token: write | ||
| contents: read | ||
|
|
||
| env: | ||
| INTEGRATION_ENVIRONMENT_ID: ${{ secrets.INTEGRATION_ENVIRONMENT_ID }} | ||
|
|
||
| name: publish-to-npm | ||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| cache: 'pnpm' | ||
|
|
||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm run build | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. two things on publish:
|
||
| - run: pnpm run test | ||
|
|
||
| - run: pnpm publish --access=public --no-git-checks | ||
| if: ${{!github.event.release.prerelease}} | ||
| - run: pnpm publish --tag prerelease --access=public --no-git-checks | ||
| if: ${{github.event.release.prerelease}} | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: Tests & Coverage | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| env: | ||
| INTEGRATION_ENVIRONMENT_ID: ${{ secrets.INTEGRATION_ENVIRONMENT_ID }} | ||
| INTEGRATION_MANAGEMENT_API_KEY: ${{ secrets.INTEGRATION_MANAGEMENT_API_KEY }} | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| - name: Use Node.js from .nvmrc file | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm run test |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| # Custom | ||
| .editorconfig | ||
| .env | ||
| .claude/settings.local.json | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't whole .claude be in gitignore (genuinely don't know what is the best practise here) |
||
|
|
||
| # See http://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # compiled output | ||
| /definitions | ||
| /dist | ||
| /bundles | ||
| /tmp | ||
| /coverage | ||
| /out-tsc | ||
|
|
@@ -34,6 +38,7 @@ | |
| /coverage | ||
| /libpeerconnection.log | ||
| npm-debug.log | ||
| package-lock.json | ||
| testem.log | ||
| /typings | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,10 @@ | ||
| # Ignore everything | ||
| * | ||
|
|
||
| # But descend into directories | ||
|
|
||
| # Recursively allow files under subtree | ||
| !/lib/** | ||
| # And allow following | ||
| !/dist/** | ||
| !package.json | ||
| !.npmignore | ||
| !README.md | ||
| !LICENSE.md | ||
|
|
||
|
|
||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| lts/* | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,34 @@ | ||
| { | ||
| "typescript.tsdk": "node_modules\\typescript\\lib", | ||
| } | ||
| "typescript.tsdk": "node_modules\\typescript\\lib", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this |
||
| "files.eol": "\n", | ||
| "typescript.updateImportsOnFileMove.enabled": "always", | ||
| "editor.defaultFormatter": "biomejs.biome", | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.biome": "explicit", | ||
| "source.organizeImports.biome": "explicit" | ||
| }, | ||
| "editor.formatOnSave": true, | ||
| "typescript.format.enable": false, | ||
| "javascript.format.enable": false, | ||
| "[markdown]": { | ||
| "editor.formatOnSave": true | ||
| }, | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[typescriptreact]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[jsonc]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[scss]": { | ||
| "editor.defaultFormatter": "vscode.css-language-features" | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file needed? :D